From: MaJun <majun258@huawei.com>
To: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <marc.zyngier@arm.com>,
<tglx@linutronix.de>, <dingtianhong@huawei.com>,
<guohanjun@huawei.com>, <majun258@huawei.com>
Subject: [PATCH] generic: Add the exception case checking routine for ppi interrupt
Date: Tue, 30 Aug 2016 12:17:19 +0800 [thread overview]
Message-ID: <1472530639-21616-1-git-send-email-majun258@huawei.com> (raw)
From: Ma Jun <majun258@huawei.com>
During system booting, if the interrupt which has no action registered
is triggered, it would cause system panic when try to access the
action member.
Signed-off-by: Ma Jun <majun258@huawei.com>
---
kernel/irq/chip.c | 20 ++++++++++++++++----
1 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 8114d06..9a0e872 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -766,11 +766,23 @@ handle_percpu_irq(unsigned int irq, struct irq_desc *desc)
*/
void handle_percpu_devid_irq(unsigned int irq, struct irq_desc *desc)
{
- struct irq_chip *chip = irq_desc_get_chip(desc);
- struct irqaction *action = desc->action;
- void *dev_id = raw_cpu_ptr(action->percpu_dev_id);
+ struct irq_chip *chip = NULL;
+ struct irqaction *action;
+ void *dev_id;
irqreturn_t res;
+ action = desc->action;
+
+ /* Unexpected interrupt in some execption case
+ * we just send eoi to end this interrupt
+ */
+ if (unlikely(!action)) {
+ mask_irq(desc);
+ goto out;
+ }
+ dev_id = raw_cpu_ptr(action->percpu_dev_id);
+
+ chip = irq_desc_get_chip(desc);
kstat_incr_irqs_this_cpu(irq, desc);
if (chip->irq_ack)
@@ -779,7 +791,7 @@ void handle_percpu_devid_irq(unsigned int irq, struct irq_desc *desc)
trace_irq_handler_entry(irq, action);
res = action->handler(irq, dev_id);
trace_irq_handler_exit(irq, action, res);
-
+out:
if (chip->irq_eoi)
chip->irq_eoi(&desc->irq_data);
}
--
1.7.1
next reply other threads:[~2016-08-30 4:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 4:17 MaJun [this message]
2016-08-30 8:50 ` Marc Zyngier
2016-08-30 10:35 ` majun (F)
2016-08-30 11:07 ` Marc Zyngier
2016-08-30 11:21 ` Mark Rutland
2016-08-31 6:35 ` majun (F)
2016-08-31 8:35 ` Marc Zyngier
2016-09-01 8:15 ` majun (F)
2016-09-01 9:03 ` Marc Zyngier
2016-09-02 13:08 ` Thomas Gleixner
2016-09-02 15:49 ` Marc Zyngier
2016-09-02 16:13 ` [tip:irq/core] genirq: Robustify handle_percpu_devid_irq() tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472530639-21616-1-git-send-email-majun258@huawei.com \
--to=majun258@huawei.com \
--cc=dingtianhong@huawei.com \
--cc=guohanjun@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®