From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758067AbcH3KkI (ORCPT ); Tue, 30 Aug 2016 06:40:08 -0400 Received: from mail-cys01nam02on0070.outbound.protection.outlook.com ([104.47.37.70]:41108 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757740AbcH3KkC (ORCPT ); Tue, 30 Aug 2016 06:40:02 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; From: Bharat Kumar Gogada To: , , , , , , CC: , , , , Bharat Kumar Gogada Subject: [PATCH 1/3] PCI: Xilinx NWL PCIe: Expanding PCIe core errors and printing event occurred. Date: Tue, 30 Aug 2016 16:09:16 +0530 Message-ID: <1472553558-27215-1-git-send-email-bharatku@xilinx.com> X-Mailer: git-send-email 2.1.1 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22544.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(189002)(199003)(90966002)(4001430100002)(11100500001)(19580405001)(46386002)(45336002)(356003)(5003940100001)(626004)(2201001)(5660300001)(48376002)(586003)(87936001)(33646002)(52956003)(50466002)(7846002)(81166006)(8676002)(81156014)(305945005)(229853001)(50226002)(8936002)(42186005)(5001770100001)(19580395003)(63266004)(36756003)(189998001)(36386004)(106466001)(86362001)(107886002)(47776003)(2906002)(103686003)(4326007)(50986999)(92566002)(107986001)(5001870100001)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0201MB1504;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM02FT031;1:OkoI0/Y5MI22txsO9Jgom+FfhwXGB5D5W13yxz5XGDy4jB6BAkh19MnSBsczUkMnLgi21gVn53mKMbCTQ1WYdB8fGUXofaWihJlbqCJZRBTA9GnWBJmpgIMsypKITf0mQ7ZiWXbZeUgl510sKk6vdCndVHQApMEdZZSs8fKOR7u8W4DBPBUytsIvbVy1PQ5FNMc8TyeOrG5eXUGWBsiYPmf9DLdb6T2D7h/D3sP3FtXdk8rGczhjM62URT6spj4OMIQrqSJjelE6kW04hnSFOVddVTmh2sza5Rb01008Xlcc3Dsew+hWIXV1oSNjyERtmkkDaBYHDyTMOP96eRfi7PCxOP73KybWfzTzK9TPRgf7A0PiqRbd2rgJpX2abVtGnOikQKNbSzMTk1RaDrwwJd2qJDFIPYzoIMotuqzVigLkVlNfZxC8cgS0SSbMGBMqdvU6kA3IsNkZweAUTcxAhBwS79ix4qvBJd3VVLYYSwYgfudGih0GXOtJJxmZ16xbCY4R9EKiw/AG+SlR5b73JXw2aWPysWkuzKVSyg2MZ+zLWE1imLSmtTndbpJ0A7KXN1RqBwlTjTpp/KXR7Sb/8VkQO9c1JjFaAJQVW+NJvQlN4hSUL3CO3QD8XMYbp/9f MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 701c08a6-c54c-4a7d-181f-08d3d0c1fb0c X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1504;2:cApaMh7neIfUYE6/+NkWZO9jkB+4lp0pVTXhfgaKv0NVMfusqiqwzmyJBH8Olw3gnaCdPXN7xo/njjQOgCImqmmxailzSMbI2O/CTQsFyaOHeKPqsPnoDzK6YSeijJejbjoIrOGDgz2qm67NG9uAr6FGge6vrx2/91kMLBnbCWohqq/riMpxFaxELlbZM9LL;3:0cctI3Zzy0GA8Fy3EVIgXHmE5tEilFS7IGJRtDZbKOhb7sD2tIAua44gtEaQcSS6vCL4kLAHyeE1B2cmD1mbkWgvrHQGWEV80KIP4WF+7qWNjcIXoKTuI725OkqmOHA06vgn33VHoXuk2u6yq/jaUlyBgjhLFusyxqnIKmIh/dBWbvNSqSJ+O3CZDhD4i5z1Ep64mAVuDYEqsbaoSgnL/nZPp9XTlu+DeZspJ6WRZl+Ng6mJ3MmoXj5vrpl4VH4uuuvIeU6S3M/Q2UG8zqOsSQ==;25:lI5FvxqZI5DGoXZ1lUT0Kx8pIz+U87eFBia7UJiz3pXtEYPc47gSiYf8GJTAbvHuKrDm5MYLOg9hTd/y6ooQJsCsCFSPkcjqnlscs0ULm0IfKw6dLyWEFya9EX2HeC/wFiV8UH4bFOsfo+FsUJphrTpsTlNGYN2rvi3zl15NYgOk0WL1dxlQWDDpID/TyYZEORT64ufet/zQzeDyAiRnSgrawEEiVqYMyvEywsWp3kHKGnQK9iTjFBv2NYkPo/VU0cXTqwboU/Xj+gkD5aNLUQOhsch11thniW3rd92Ck9JvZJFCrsAD/rVlVXTa0agNmddULfGzcPlGUn1ht4Lpsco/huhv7qYQG0+9/+A8xLwY+yB7nY4iWRteAZzFpu6kVvhcZjzY3O5iGnyyIQYOJ+Vsir0FAhYy+w6HqayTaIk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:SN1PR0201MB1504; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1504;31:Lg4TGcUhCqP45aH+JK7Cd0Rmvlr5dMRPvEI/PxaVYUu8pbCK3AyFE2BW1tB+4jwukNmMBhwMhKlS0RNNqGSn8HwVOfq8Aa2IShjKzjI2FYi9s1Bw4sIzvddc35+7zRS/0q23bkHRE/KDudeiDWPZpnS+3rKThfqj6+DaoDc6vw4nxGBA0JeYZRNDcGSxcFDiCGQuqLNR5NKoP1xj+wwlaF0gcK6R1O4Vm4J2HqPKH88=;20:uRxeGbmei+ENXA/ZBTmG2Vw5WqYNkl8T0U3gdaY/5Y+yXRyLeNPWUn/eon5eYNtyGCtlJslOYK0274xNO2G3vbeZC/0sl2EXN1AmeHwZwJKgESjbwmztuduv+254xjq7eriDP+tg2oKT1XcVJ6mCTep4GRdexq8PZZsdMg3qAXEXfupvpSvzENnvVzpOpT63vhTJ6sawsm26ox+uEw1vnPLRA43FNdvDrGpjlDIMlczvvZV53DYw5XnOR5Vo5fCJkJXZTTNi83sW/KqU4/8Qs3jI7/RtpBFEZwNMgD/mPkr5a7Lhyt7CYiQSWESZ3Ev9+U/zjHgvrBMz7qYdHRxfSlqLsD27zlyfWhkoqRW3w8l1RJOPQsQozOFUb7k904/+tkZQe80jMIKjDjB/iI/Xej13viR1DkjgMAUMsQ491WnsTgEirpvRk3ty80xBtr6hr7JH9qAHJSWEs6ssDO1RaT2dPbOK4FzRGQjAbBx0u+kEL+MFQiHnCzarruwM7KV8 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13015025)(8121501046)(5005006)(13017025)(13018025)(13024025)(13023025)(10201501046)(3002001)(6055026);SRVR:SN1PR0201MB1504;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0201MB1504; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1504;4:+FS0389DsxZMWCV7CCTHM+rQV5dWU0TlLdnm5Q59ubcT7G44bwESgrYZUNxxWzAjKzMyhjPppfSxhwwunxYbHSLdtc4No/oj+oWo+npGED5S+3xRLjrzxzD9CUlJ3XZJjZFf699vQjd9Aal+Q+sAoCXGDu1wcbEVEP0QRvV8RyfE6iCDo3SBntQab0hwm8RHuniWoim18di9DSYn6+PtcbW5XoXAA/MS3fEbeLdaUzG5CecmGA6BjsS/CXLTm5xdevSofJgPttEDCrVI8bW3mIoyzcI6ce/MQsvUptjW6o6bbxK1NYvtojjAHNmfdMlmjPJ7VtGCJ62y7F5AXP4Or6rZViXON4U3ntKd71R59rzQPm8TDKN+jsrJ73sA7bfwkpxlSoJ3ouexBUuwhPnn3XQ/mNtBVVFIH8Sp7J2Y6nIv4BlyPD7Za9/gD+brpCUBczEXONeviGjk3s9EDAmQHq0mmRTtNj/ezztxZn2o2CJVW9Dw8jcvHTkngUwlq+g+b3Jgkwf+T7sz4Xu37R0v6cJShrBpKcFwp8aRZQJkKic= X-Forefront-PRVS: 0050CEFE70 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR0201MB1504;23:YJpn5g9IjD08iX72qN1JmgPJ+xKxKl585yDygGN?= =?us-ascii?Q?TCEZrir/Q84txVC7DcSn7feBEVdC1aX5NOCewQH04ShhrFOE1ovOiB5g137O?= =?us-ascii?Q?/RIHjo39wfw6n+oXXfcQCh5AjXKorknF6ESweEO3aP2p2kpzNy009SqhJGDj?= =?us-ascii?Q?d4v/Kk02KBlR0bNJSbCYxmDB0qGPFlt2c3TBUZwpaK/vvQiab+x2dadIbYxY?= =?us-ascii?Q?OgCOMMI03pKfuL+hKS31IZt0pDZ0e3cKvR5luL9n36OikCtDn7zZxmSFv3PU?= =?us-ascii?Q?NkRKH71KrMfiYWZKGEhBApZva/OYklPwPdxKd65xTFge/ACLmkEBPrNkEqyH?= =?us-ascii?Q?HhSn8unY5yKKOiIOrjm5wiszVFmjbdvGAgJGEBhczKyNJAjTKa0S2vCGSbGT?= =?us-ascii?Q?y9fLWFVotIDvo9MEU7g6NSduq2I48j5gRrp6Kqz/RxotDvrB/KUwDfGNZWfi?= =?us-ascii?Q?q6iZ0SsanpxwuPL+V4xL+p+T6sX39s70f9IlxFNeZOvyIr8pc2F+9ISR83Cn?= =?us-ascii?Q?nfRxDO7vzHFRhjfMTkHnDiFHENY5E2qN4WGrKGtchM6VIn/WKTy1uVDVeyP4?= =?us-ascii?Q?kWmhQtAVVg5jCLziHuxJ/mVmEvgHRKKcuH00LANAKeoJxw6SkN8R3MNiOI4s?= =?us-ascii?Q?WWNF0R/a4/oHFEXaU2hugnmE5xFE2qFm8ijkSuYix+PheatqgC3axPpMf+oa?= =?us-ascii?Q?9zQGtGz3ug9phRy5nWNgCh46hOHbK6CJzGnP33dpdkyc0OK7XFWip3xJ/BF6?= =?us-ascii?Q?cNxGMs+V/zFsTzwvztkTBRlod8upN6Fp1Py5LVBOb+2CjysC6kqaql933Rk5?= =?us-ascii?Q?fnAUJSu3mxlhzbxQCBNIC9QR6jYNn4MEOypZypuaSN2OM8vC65NqdlS8LXJD?= =?us-ascii?Q?aC1AePAVaM1ibRYJRGYen2/1b/4fAFtiOB0TKTTLxCqE9ayr7iiM5X9cLnZa?= =?us-ascii?Q?S3e9ci1B6wn1UG0Sb+oevcqC++xTN2X4JppW0g++AOyI/D/3CFoNkZK+tcUT?= =?us-ascii?Q?nNttlpsJljqLQzybvx+5A6zpbSaBfsTPLtTzVeFtCyX8ipkXJqw8DnDZWZQn?= =?us-ascii?Q?4uLmJD4eEdzGyMJG50VLEY0Ue+HlnMg8QnHHRm68b4XRH3LQfibVPZRdIGDH?= =?us-ascii?Q?+q7CZ/h3KcWzoEYscD0YbIgDQ7+H1eC7YQa9LRsLPW4ecOTK37fppDLdhpnl?= =?us-ascii?Q?kNCK4uHDU0ROPQKh4LE1WhkdS2s8tHE0T2c0hxL3Sqjy4Jpoyp07WDjqtxQ?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1504;6:+swM1h5VIpC6pbf25YMHwHwBBTHZqZpzESqRLUx3ZM06fXKr+YAeIWcP7/OJ9tOT5Dy/HtvOPBpMG3tAPVmC5htwE4cFmNb9/nbplKid7LFigomLV1xXewzgDjpfKsLDvVhfES0mAy8QmLLLwv5Bg7YwTmlYTFMQe0Ck1/BBnMLPOZ683mEBdMfcO4Qhkmil7oSw7JvZAIfwLG0JKtYxYNX3WKracmuu7/Xku5Occ9WwkZEyP1gXYh1TXulp3wJQeboCmT3EdIdOB7cKWeNlogUSi9dRGHx9LrhVUI/Xhez0QJVmTnYnPRSNTZ8Nt2fwWNoeS141ig6BZXdH8x3sOA==;5:mj8Oos7tOKiH9q/gzWg2K6kDdsarcpVmGFUPXuutCmIqzo/Gu7VewDpObJ76q73Eslfhw+6WRCg+p7TEaTeXEbblffrA+gSxVNbzh+7ihbbttvTA7EA4SjTJid458ODB6i0S15VKcrq2mxUqOL3jCw==;24:TC9BIXkZ8oZn8Cp/bKoV2CzNExb2G2XXLIpaUInWGaoPSr+9QeTdkJZPUY4X84YaZ+CVjEoHzqrEGYcox8i/w2Q7Cy1er5QCF2msDiEKpYM=;7:3eAO9NoljPuMORBmETLnZR5d9vzkgZpdKNqJAnruEqqQhk26XkysMgImlzx8Tb0GK+Fssw4L+XtQTheucHJ2DxhhSquePMM5In56+MrGoWyKfWNOMYk4Rt8/YwvuAAL5PVh2oSjIpNHApEaYeiTkHKle+ho1wwjurRuSfUCCx1/tUNqY//SOq0Nsyyqhmc4IDKB3IQfQwPolgU50Tx1XnZXe5+m7v80+DpIsl8cQHENMO6Vx7URmlN4iRQ5EpjWj SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2016 10:39:54.4292 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1504 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The current driver prints pcie core error, for all core events. Instead of just printing PCIe core error, now adding prints to show individual core events occurred. Signed-off-by: Bharat Kumar Gogada --- drivers/pci/host/pcie-xilinx-nwl.c | 48 +++++++++++++++++++++++++++++++------- 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/drivers/pci/host/pcie-xilinx-nwl.c b/drivers/pci/host/pcie-xilinx-nwl.c index 3479d30..86c1834 100644 --- a/drivers/pci/host/pcie-xilinx-nwl.c +++ b/drivers/pci/host/pcie-xilinx-nwl.c @@ -85,10 +85,15 @@ #define MSGF_MISC_SR_MASTER_ERR BIT(5) #define MSGF_MISC_SR_I_ADDR_ERR BIT(6) #define MSGF_MISC_SR_E_ADDR_ERR BIT(7) -#define MSGF_MISC_SR_UR_DETECT BIT(20) - -#define MSGF_MISC_SR_PCIE_CORE GENMASK(18, 16) -#define MSGF_MISC_SR_PCIE_CORE_ERR GENMASK(31, 22) +#define MSGF_MISC_SR_FATAL_AER BIT(16) +#define MSGF_MISC_SR_NON_FATAL_AER BIT(17) +#define MSGF_MISC_SR_CORR_AER BIT(18) +#define MSGF_MISC_SR_UR_DETECT BIT(20) +#define MSGF_MISC_SR_NON_FATAL_DEV BIT(22) +#define MSGF_MISC_SR_FATAL_DEV BIT(23) +#define MSGF_MISC_SR_LINK_DOWN BIT(24) +#define MSGF_MSIC_SR_LINK_AUTO_BWIDTH BIT(25) +#define MSGF_MSIC_SR_LINK_BWIDTH BIT(26) #define MSGF_MISC_SR_MASKALL (MSGF_MISC_SR_RXMSG_AVAIL | \ MSGF_MISC_SR_RXMSG_OVER | \ @@ -96,9 +101,15 @@ MSGF_MISC_SR_MASTER_ERR | \ MSGF_MISC_SR_I_ADDR_ERR | \ MSGF_MISC_SR_E_ADDR_ERR | \ + MSGF_MISC_SR_FATAL_AER | \ + MSGF_MISC_SR_NON_FATAL_AER | \ + MSGF_MISC_SR_CORR_AER | \ MSGF_MISC_SR_UR_DETECT | \ - MSGF_MISC_SR_PCIE_CORE | \ - MSGF_MISC_SR_PCIE_CORE_ERR) + MSGF_MISC_SR_NON_FATAL_DEV | \ + MSGF_MISC_SR_FATAL_DEV | \ + MSGF_MISC_SR_LINK_DOWN | \ + MSGF_MSIC_SR_LINK_AUTO_BWIDTH | \ + MSGF_MSIC_SR_LINK_BWIDTH) /* Legacy interrupt status mask bits */ #define MSGF_LEG_SR_INTA BIT(0) @@ -291,8 +302,29 @@ static irqreturn_t nwl_pcie_misc_handler(int irq, void *data) dev_err(pcie->dev, "In Misc Egress address translation error\n"); - if (misc_stat & MSGF_MISC_SR_PCIE_CORE_ERR) - dev_err(pcie->dev, "PCIe Core error\n"); + if (misc_stat & MSGF_MISC_SR_FATAL_AER) + dev_err(pcie->dev, "Fatal Error in AER Capability\n"); + + if (misc_stat & MSGF_MISC_SR_NON_FATAL_AER) + dev_err(pcie->dev, "Non-Fatal Error in AER Capability\n"); + + if (misc_stat & MSGF_MISC_SR_CORR_AER) + dev_err(pcie->dev, "Correctable Error in AER Capability\n"); + + if (misc_stat & MSGF_MISC_SR_UR_DETECT) + dev_err(pcie->dev, "Unsupported request Detected\n"); + + if (misc_stat & MSGF_MISC_SR_NON_FATAL_DEV) + dev_err(pcie->dev, "Non-Fatal Error Detected\n"); + + if (misc_stat & MSGF_MISC_SR_FATAL_DEV) + dev_err(pcie->dev, "Fatal Error Detected\n"); + + if (misc_stat & MSGF_MSIC_SR_LINK_AUTO_BWIDTH) + dev_info(pcie->dev, "Link Autonomous Bandwidth Management Status bit set\n"); + + if (misc_stat & MSGF_MSIC_SR_LINK_BWIDTH) + dev_info(pcie->dev, "Link Bandwidth Management Status bit set\n"); /* Clear misc interrupt status */ nwl_bridge_writel(pcie, misc_stat, MSGF_MISC_STATUS); -- 2.1.1