From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935893AbcHaQ3z (ORCPT ); Wed, 31 Aug 2016 12:29:55 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:34732 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935808AbcHaQ2v (ORCPT ); Wed, 31 Aug 2016 12:28:51 -0400 From: Sudip Mukherjee To: Jiri Kosina , Benjamin Tissoires Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-input@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] HID: usbkbd: return proper error code Date: Wed, 31 Aug 2016 21:58:21 +0530 Message-Id: <1472660901-1912-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use proper error code instead of using -1 on failure to allocate memory. We may use the error code later in the caller. Signed-off-by: Sudip Mukherjee --- drivers/hid/usbhid/usbkbd.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c index 9a332e6..ee53359 100644 --- a/drivers/hid/usbhid/usbkbd.c +++ b/drivers/hid/usbhid/usbkbd.c @@ -249,15 +249,15 @@ static void usb_kbd_close(struct input_dev *dev) static int usb_kbd_alloc_mem(struct usb_device *dev, struct usb_kbd *kbd) { if (!(kbd->irq = usb_alloc_urb(0, GFP_KERNEL))) - return -1; + return -ENOMEM; if (!(kbd->led = usb_alloc_urb(0, GFP_KERNEL))) - return -1; + return -ENOMEM; if (!(kbd->new = usb_alloc_coherent(dev, 8, GFP_ATOMIC, &kbd->new_dma))) - return -1; + return -ENOMEM; if (!(kbd->cr = kmalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL))) - return -1; + return -ENOMEM; if (!(kbd->leds = usb_alloc_coherent(dev, 1, GFP_ATOMIC, &kbd->leds_dma))) - return -1; + return -ENOMEM; return 0; } -- 1.9.1