From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933175AbcIAP2G (ORCPT ); Thu, 1 Sep 2016 11:28:06 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33678 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755378AbcIAP2A (ORCPT ); Thu, 1 Sep 2016 11:28:00 -0400 From: Manfred Spraul To: benh@kernel.crashing.org, paulmck@linux.vnet.ibm.com, Ingo Molnar , Boqun Feng , Peter Zijlstra , Andrew Morton Cc: LKML , will.deacon@arm.com, 1vier1@web.de, Davidlohr Bueso , Manfred Spraul Subject: [PATCH 9/7] ipc/sem.c: Remove another memory barrier. Date: Thu, 1 Sep 2016 17:27:53 +0200 Message-Id: <1472743673-15585-2-git-send-email-manfred@colorfullife.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1472743673-15585-1-git-send-email-manfred@colorfullife.com> References: <1472743673-15585-1-git-send-email-manfred@colorfullife.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As spin_unlock_wait() is defined as equivalent to spin_lock(); spin_unlock(), the memory barrier before spin_unlock_wait() is not required. Signed-off-by: Manfred Spraul --- ipc/sem.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/ipc/sem.c b/ipc/sem.c index a5da82c..2bef9c0 100644 --- a/ipc/sem.c +++ b/ipc/sem.c @@ -280,11 +280,7 @@ static void complexmode_enter(struct sem_array *sma) return; } - /* We need a full barrier after seting complex_mode: - * The write to complex_mode must be visible - * before we read the first sem->lock spinlock state. - */ - smp_store_mb(sma->complex_mode, true); + sma->complex_mode = true; for (i = 0; i < sma->sem_nsems; i++) { sem = sma->sem_base + i; -- 2.7.4