From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754432AbcICRd1 (ORCPT ); Sat, 3 Sep 2016 13:33:27 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36214 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753565AbcICRdZ (ORCPT ); Sat, 3 Sep 2016 13:33:25 -0400 From: Sabitha George To: gregkh@linuxfoundation.org, wsa@the-dreams.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: Sabitha George Subject: [PATCH 3/5] staging: ks7010: Remove redundant null pointer check prior to kfree() Date: Sat, 3 Sep 2016 22:51:11 +0530 Message-Id: <1472923271-14890-1-git-send-email-sabitha.george@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes the warning on ks7010_sdio.c :'kfree(NULL) is safe and this check is probably not required' Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks7010_sdio.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index b16286e..67b01a6 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -716,8 +716,7 @@ static int ks7010_sdio_update_index(struct ks_wlan_private *priv, u32 index) goto error_out; } error_out: - if (data_buf) - kfree(data_buf); + kfree(data_buf); return rc; } @@ -747,8 +746,7 @@ static int ks7010_sdio_data_compare(struct ks_wlan_private *priv, u32 address, goto error_out; } error_out: - if (read_buf) - kfree(read_buf); + kfree(read_buf); return rc; } @@ -863,8 +861,7 @@ static int ks7010_upload_firmware(struct ks_wlan_private *priv, release_firmware(fw_entry); error_out0: sdio_release_host(card->func); - if (rom_buf) - kfree(rom_buf); + kfree(rom_buf); return rc; } @@ -1182,8 +1179,7 @@ static void ks7010_sdio_remove(struct sdio_func *func) unregister_netdev(netdev); trx_device_exit(priv); - if (priv->ks_wlan_hw.read_buf) - kfree(priv->ks_wlan_hw.read_buf); + kfree(priv->ks_wlan_hw.read_buf); free_netdev(priv->net_dev); card->priv = NULL; -- 1.9.1