From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754008AbcIDPAg (ORCPT ); Sun, 4 Sep 2016 11:00:36 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:36510 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753657AbcIDPAd (ORCPT ); Sun, 4 Sep 2016 11:00:33 -0400 From: Sudip Mukherjee To: Greg Kroah-Hartman , Wolfram Sang Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, Sudip Mukherjee Subject: [PATCH 2/2 RESEND] staging: ks7010: fix memory leak Date: Sun, 4 Sep 2016 20:30:19 +0530 Message-Id: <1473001219-30251-2-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1473001219-30251-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1473001219-30251-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the firmware request failed we were just returning but we missed freeing the memory and releasing the MMC Host. Signed-off-by: Sudip Mukherjee --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index 7bcf1ea..86cdebe 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -791,7 +791,7 @@ static int ks7010_upload_firmware(struct ks_wlan_private *priv, retval = request_firmware(&fw_entry, ROM_FILE, &priv->ks_wlan_hw.sdio_card->func->dev); if (retval) - return retval; + goto error_out0; length = fw_entry->size; -- 1.9.1