Re: [PATCH v4] power: bq24735-charger: Request status GPIO with initial input setup

[Paul Kocialkowski <contact@paulk.fr>]

[-- Attachment #1: Type: text/plain, Size: 1821 bytes --]

Hi,

Le lundi 05 septembre 2016 à 13:08 +0200, Sebastian Reichel a écrit :
> Hi Paul,
> 
> On Sat, Sep 03, 2016 at 12:09:53AM +0200, Paul Kocialkowski wrote:
> > 
> > This requests the status GPIO with initial input setup. it is required
> > to read the GPIO status at probe time and thus correctly avoid sending
> > i2c messages when AC is not plugged.
> > 
> > When requesting the GPIO without initial input setup, it always reads 0
> > which causes probe to fail as it assumes the charger is connected, sends
> > i2c messages and fails.
> > 
> > While at it, this switches the driver over to gpio consumer.
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> >  drivers/power/supply/bq24735-charger.c | 44 +++++++++++++----------------
> > -----
> >  include/linux/power/bq24735-charger.h  |  4 ----
> >  2 files changed, 16 insertions(+), 32 deletions(-)
> > 
> > diff --git a/drivers/power/supply/bq24735-charger.c
> > b/drivers/power/supply/bq24735-charger.c
> 
> [...]
> 
> > 
> > -	if (IS_ENABLED(CONFIG_OF) && !charger->pdata && client-
> > >dev.of_node)
> > +	if (IS_ENABLED(CONFIG_OF) && !charger->pdata && client-
> > >dev.of_node) {
> >  		charger->pdata = bq24735_parse_dt_data(client);
> > +		if (IS_ERR(charger->pdata))
> > +			return PTR_ERR(charger->pdata);
> > +	}
> 
> I queued your patch into power-supply's for-next branch, but dropped
> this change, which is from an earlier revision of this patch and no
> longer needed. Thanks for your patch.

Damn, I forgot to clean that up. Good spotting, thanks!

-- 
Paul Kocialkowski, developer of low-level free software for embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]