mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Redfearn <matt.redfearn@imgtec.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: <linux-mips@linux-mips.org>,
	Matt Redfearn <matt.redfearn@imgtec.com>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH] MIPS: rb532: Fix undefined reference to setup_serial_port
Date: Mon, 5 Sep 2016 17:18:40 +0100	[thread overview]
Message-ID: <1473092320-30019-1-git-send-email-matt.redfearn@imgtec.com> (raw)

If the rb532 machine is compiled without CONFIG_SERIAL_8250, the
following linker error occurs

arch/mips/built-in.o: In function `setup_serial_port':
(.init.text+0x20c): undefined reference to `early_serial_setup'

Fix this by wrapping registration of the rb532 uart in an ifdef
CONFIG_SERIAL_8250.

Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>

---

 arch/mips/rb532/serial.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/mips/rb532/serial.c b/arch/mips/rb532/serial.c
index 70482540b3db..f0ea2de38840 100644
--- a/arch/mips/rb532/serial.c
+++ b/arch/mips/rb532/serial.c
@@ -36,6 +36,8 @@
 
 extern unsigned int idt_cpu_freq;
 
+#ifdef CONFIG_SERIAL_8250
+
 static struct uart_port rb532_uart = {
 	.flags = UPF_BOOT_AUTOCONF,
 	.line = 0,
@@ -52,3 +54,6 @@ int __init setup_serial_port(void)
 	return early_serial_setup(&rb532_uart);
 }
 arch_initcall(setup_serial_port);
+
+#endif /* CONFIG_SERIAL_8250 */
+
-- 
2.7.4

             reply	other threads:[~2016-09-05 16:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05 16:18 Matt Redfearn [this message]
2016-09-13 16:02 ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473092320-30019-1-git-send-email-matt.redfearn@imgtec.com \
    --to=matt.redfearn@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®