From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936095AbcIFQcp (ORCPT ); Tue, 6 Sep 2016 12:32:45 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36111 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753790AbcIFQcn (ORCPT ); Tue, 6 Sep 2016 12:32:43 -0400 From: Kirill Marinushkin To: dhowells@redhat.com Cc: asavkov@redhat.com, k.marinushkin@gmail.com, paul.gortmaker@windriver.com, james.l.morris@oracle.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng. Date: Tue, 6 Sep 2016 18:32:27 +0200 Message-Id: <1473179547-12101-1-git-send-email-k.marinushkin@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <32083.1473167516@warthog.procyon.org.uk> References: <32083.1473167516@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The other thing is that I have been given a conflicting patch (see > below). Is your fix preferable? The patch you attached previously is v1; I submitted v2 after review by Stephan Mueller. I additionally attach it here below. IMO, the preferable fix depends on your future plan. If you plan to continue using both ANSI X9.31 DRNG and DRBG - I agree with the patch suggested by Artem Savkov. If you plan to reduce using ANSI X9.31 DRNG and use DRBG more widely - I suggest my patch. Best Regards, Kirill --- From Kirill Marinushkin Subject [PATCH v2] KEYS: fix big_key dependency Date Tue, 16 Aug 2016 21:51:12 +0200 This patch fixes the following bug: [oss-security] - panic at big_key_preparse #4.7-r6/rc7 & master Signed-off-by: Kirill Marinushkin --- security/keys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/keys/Kconfig b/security/keys/Kconfig index f826e87..5bc5114 100644 --- a/security/keys/Kconfig +++ b/security/keys/Kconfig @@ -44,7 +44,7 @@ config BIG_KEYS select CRYPTO select CRYPTO_AES select CRYPTO_ECB - select CRYPTO_RNG + select CRYPTO_RNG_DEFAULT