mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Elias Boutaleb <kagekyio@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, trivial@kernel.org,
	linux-kernel@vger.kernel.org,
	Elias Boutaleb <elias.boutaleb@etu.upmc.fr>
Subject: [PATCH] [trivial] comedi/dt2811: fix warnings on globals
Date: Tue,  6 Sep 2016 23:40:34 +0200	[thread overview]
Message-ID: <1473198034-8428-1-git-send-email-kagekyio@gmail.com> (raw)

From: Elias Boutaleb <elias.boutaleb@etu.upmc.fr>

This patch fixes the following two warnings on the dt2811 driver found using sparse:

drivers/staging/comedi/drivers/dt2811.c:99:20: warning: symbol 'dt2811_clk_dividers' was not declared. Should it be static?
drivers/staging/comedi/drivers/dt2811.c:103:20: warning: symbol 'dt2811_clk_multipliers' was not declared. Should it be static?

---
 drivers/staging/comedi/drivers/dt2811.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/dt2811.c b/drivers/staging/comedi/drivers/dt2811.c
index 8bbd938..fcd8547 100644
--- a/drivers/staging/comedi/drivers/dt2811.c
+++ b/drivers/staging/comedi/drivers/dt2811.c
@@ -96,11 +96,11 @@
  *    6      6      100 kHz	 6   1000000
  *    7     12       50 kHz	 7   10000000
  */
-const unsigned int dt2811_clk_dividers[] = {
+static const unsigned int dt2811_clk_dividers[] = {
 	1, 10, 2, 3, 4, 5, 6, 12
 };

-const unsigned int dt2811_clk_multipliers[] = {
+static const unsigned int dt2811_clk_multipliers[] = {
 	1, 10, 100, 1000, 10000, 100000, 1000000, 10000000
 };

--
2.7.4

                 reply	other threads:[~2016-09-06 21:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473198034-8428-1-git-send-email-kagekyio@gmail.com \
    --to=kagekyio@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=elias.boutaleb@etu.upmc.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®