From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754569AbcILSLk (ORCPT ); Mon, 12 Sep 2016 14:11:40 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:23417 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbcILSLj (ORCPT ); Mon, 12 Sep 2016 14:11:39 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com u8CIApem017710 X-Nifty-SrcIP: [111.169.71.157] From: Masahiro Yamada To: linux-s390@vger.kernel.org Cc: Masahiro Yamada , Heiko Carstens , Michael Holzheu , linux-kernel@vger.kernel.org, Alexander Kuleshov , Martin Schwidefsky Subject: [PATCH] s390: cleanup with list_first_entry_or_null() Date: Tue, 13 Sep 2016 03:10:39 +0900 Message-Id: <1473703839-1185-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The combo of list_empty() check and return list_first_entry() can be replaced with list_first_entry_or_null(). Signed-off-by: Masahiro Yamada --- arch/s390/kernel/crash_dump.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/s390/kernel/crash_dump.c b/arch/s390/kernel/crash_dump.c index 29df848..621907d 100644 --- a/arch/s390/kernel/crash_dump.c +++ b/arch/s390/kernel/crash_dump.c @@ -71,9 +71,8 @@ struct save_area * __init save_area_alloc(bool is_boot_cpu) */ struct save_area * __init save_area_boot_cpu(void) { - if (list_empty(&dump_save_areas)) - return NULL; - return list_first_entry(&dump_save_areas, struct save_area, list); + return list_first_entry_or_null(&dump_save_areas, struct save_area, + list); } /* -- 1.9.1