From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932624AbcILT3p (ORCPT ); Mon, 12 Sep 2016 15:29:45 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:38527 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757574AbcILT3e (ORCPT ); Mon, 12 Sep 2016 15:29:34 -0400 From: Miklos Szeredi To: linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Al Viro Subject: [PATCH 05/17] bad_inode: use generic_readlink Date: Mon, 12 Sep 2016 21:29:07 +0200 Message-Id: <1473708559-12714-6-git-send-email-mszeredi@redhat.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1473708559-12714-1-git-send-email-mszeredi@redhat.com> References: <1473708559-12714-1-git-send-email-mszeredi@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This will allow us to move the generic readlink logic into the VFS and get rid of the readlink method. If inode has i_link set then this patch changes behavior, because generic_readlink will return the cached contents instead of calling i_op->get_link. It would be hard to imagine that this change could break userspace in any sane setup, though. Signed-off-by: Miklos Szeredi --- fs/bad_inode.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/bad_inode.c b/fs/bad_inode.c index b8db8531e837..7cf1f445fe04 100644 --- a/fs/bad_inode.c +++ b/fs/bad_inode.c @@ -78,12 +78,6 @@ static int bad_inode_rename2(struct inode *old_dir, struct dentry *old_dentry, return -EIO; } -static int bad_inode_readlink(struct dentry *dentry, char __user *buffer, - int buflen) -{ - return -EIO; -} - static int bad_inode_permission(struct inode *inode, int mask) { return -EIO; @@ -178,7 +172,7 @@ static const struct inode_operations bad_inode_ops = .rmdir = bad_inode_rmdir, .mknod = bad_inode_mknod, .rename2 = bad_inode_rename2, - .readlink = bad_inode_readlink, + .readlink = generic_readlink, .permission = bad_inode_permission, .getattr = bad_inode_getattr, .setattr = bad_inode_setattr, -- 2.5.5