From: Michael Straube <straube.linux@gmail.com>
To: Joe Perches <joe@perches.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: cleanup long line in odm.c
Date: Thu, 26 Mar 2020 09:45:44 +0100 [thread overview]
Message-ID: <147371c7-54f9-3d17-b497-24044aa5c654@gmail.com> (raw)
In-Reply-To: <9b369028adca4105c376094db569637cf8bb1fa2.camel@perches.com>
On 2020-03-26 01:08, Joe Perches wrote:
> On Wed, 2020-03-25 at 22:59 +0100, Michael Straube wrote:
>> Cleanup line over 80 characters by removing unnecessary parentheses.
> []
>> diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c
> []
>> @@ -590,7 +590,7 @@ void odm_CCKPacketDetectionThresh(struct odm_dm_struct *pDM_Odm)
>> if (pDM_Odm->bLinked) {
>> if (pDM_Odm->RSSI_Min > 25) {
>> CurCCK_CCAThres = 0xcd;
>> - } else if ((pDM_Odm->RSSI_Min <= 25) && (pDM_Odm->RSSI_Min > 10)) {
>> + } else if (pDM_Odm->RSSI_Min <= 25 && pDM_Odm->RSSI_Min > 10) {
>
> The test above this already guarantees pDM_Odm->RSSI_Min <= 25
> so the block could be written just
>
> } else if (pDM->RSSI_Min > 10) {
>
Ah, yes. Thank you. :)
next prev parent reply other threads:[~2020-03-26 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 21:59 Michael Straube
2020-03-26 0:08 ` Joe Perches
2020-03-26 8:45 ` Michael Straube [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-24 17:21 Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147371c7-54f9-3d17-b497-24044aa5c654@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome