From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757518AbcILWEq (ORCPT ); Mon, 12 Sep 2016 18:04:46 -0400 Received: from p3plsmtps2ded04.prod.phx3.secureserver.net ([208.109.80.198]:53394 "EHLO p3plsmtps2ded04.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756564AbcILWEn (ORCPT ); Mon, 12 Sep 2016 18:04:43 -0400 x-originating-ip: 72.167.245.219 From: Long Li To: "K. Y. Srinivasan" , Haiyang Zhang , Bjorn Helgaas Cc: devel@linuxdriverproject.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Long Li Subject: [PATCH 2/2] pci-hyperv: properly handle device eject Date: Mon, 12 Sep 2016 16:54:01 -0700 Message-Id: <1473724441-21207-2-git-send-email-longli@exchange.microsoft.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1473724441-21207-1-git-send-email-longli@exchange.microsoft.com> References: <1473724441-21207-1-git-send-email-longli@exchange.microsoft.com> X-CMAE-Envelope: MS4wfP1LRWPzKE83NRyHngFkP5m0SUUTAOvCjGblVIUvC2I7jYirphSZHxkfX0pFc8lDXWiQ5FKJ8GK6vwBP/ehPOBcCjugjU+7mvqNeJ6v0aKdkHqIvC0Sl lc2M9HSJfla2fsu8lBAwU5hhYJMjqm9d8FS0mkZYpUZhVa2zceUivpEnHvm+cj+3/HzwjiBbHISzno6eYLFywn2XcvFY3Vlzcf8Qhnn4CFDIqKvV54Rrio3u eIRDVMaVh1Ry8UY00WydXqcm7kaasRdWakWGeQC4Ht9/v1S+taSCoCjPfdmpGrp8e6g5enPUSEebDgLVgy4Q4o50izQi05qmfYMgLeSmnije6fYYrvbadGa5 UbkfKEaUGwMhDnX8HCpnndq31pAcHEd3YgqeGX6BdUDIHwDL3oY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Long Li A PCI_EJECT message can arrive at the same time we are calling pci_scan_child_bus in the workqueue for the previous PCI_BUS_RELATIONS message, in this case we could potentailly modify the bus from two places. Properly lock the bus access. Signed-off-by: Long Li --- drivers/pci/host/pci-hyperv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c index 3c2b330..ca77009 100644 --- a/drivers/pci/host/pci-hyperv.c +++ b/drivers/pci/host/pci-hyperv.c @@ -1587,7 +1587,7 @@ static void hv_eject_device_work(struct work_struct *work) pdev = pci_get_domain_bus_and_slot(hpdev->hbus->sysdata.domain, 0, wslot); if (pdev) { - pci_stop_and_remove_bus_device(pdev); + pci_stop_and_remove_bus_device_locked(pdev); pci_dev_put(pdev); } -- 1.8.5.6