From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759428AbcIMQ3q (ORCPT ); Tue, 13 Sep 2016 12:29:46 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:32941 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753562AbcIMQ3o (ORCPT ); Tue, 13 Sep 2016 12:29:44 -0400 From: Amit Ghadge To: gregkh@linuxfoundation.org Cc: accessrunner-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, Amit Ghadge Subject: [PATCH] usb: atm: cxacru: Clean up if function returned NULL on failure Date: Tue, 13 Sep 2016 21:59:31 +0530 Message-Id: <1473784171-7768-1-git-send-email-amitg.b14@gmail.com> X-Mailer: git-send-email 2.5.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some functions return NULL on failure, used !x instead of x==NULL. Signed-off-by: Amit Ghadge --- drivers/usb/atm/cxacru.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index 0a866e9..95a4737 100644 --- a/drivers/usb/atm/cxacru.c +++ b/drivers/usb/atm/cxacru.c @@ -228,7 +228,7 @@ static ssize_t cxacru_sysfs_show_##_name(struct device *dev, \ struct cxacru_data *instance = to_usbatm_driver_data(\ to_usb_interface(dev)); \ \ - if (instance == NULL) \ + if (!instance) \ return -ENODEV; \ \ return cxacru_sysfs_showattr_##_type(instance->card_info[_value], buf); \ @@ -280,7 +280,7 @@ static ssize_t cxacru_sysfs_showattr_LINK(u32 value, char *buf) { static char *str[] = { NULL, "not connected", "connected", "lost" }; - if (unlikely(value >= ARRAY_SIZE(str) || str[value] == NULL)) + if (unlikely(value >= ARRAY_SIZE(str) || !str[value])) return snprintf(buf, PAGE_SIZE, "%u\n", value); return snprintf(buf, PAGE_SIZE, "%s\n", str[value]); } @@ -323,7 +323,7 @@ static ssize_t cxacru_sysfs_show_mac_address(struct device *dev, struct cxacru_data *instance = to_usbatm_driver_data( to_usb_interface(dev)); - if (instance == NULL || instance->usbatm->atm_dev == NULL) + if (!instance || !instance->usbatm->atm_dev) return -ENODEV; return snprintf(buf, PAGE_SIZE, "%pM\n", @@ -338,7 +338,7 @@ static ssize_t cxacru_sysfs_show_adsl_state(struct device *dev, to_usb_interface(dev)); u32 value; - if (instance == NULL) + if (!instance) return -ENODEV; value = instance->card_info[CXINF_LINE_STARTABLE]; @@ -365,7 +365,7 @@ static ssize_t cxacru_sysfs_store_adsl_state(struct device *dev, return -EINVAL; ret = 0; - if (instance == NULL) + if (!instance) return -ENODEV; if (mutex_lock_interruptible(&instance->adsl_state_serialize)) @@ -461,7 +461,7 @@ static ssize_t cxacru_sysfs_store_adsl_config(struct device *dev, if (!capable(CAP_NET_ADMIN)) return -EACCES; - if (instance == NULL) + if (!instance) return -ENODEV; pos = 0; -- 2.5.5