mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Cc: Christian K?nig <christian.koenig@amd.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Alexander Deucher <Alexander.Deucher@amd.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Frediano Ziglio <fziglio@redhat.com>,
	linux-kernel@vger.kernel.org,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	Dave Airlie <airlied@redhat.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: [PATCH v2 4/5] drm/qxl: squash lines for simple wrapper functions
Date: Wed, 14 Sep 2016 23:39:11 +0900	[thread overview]
Message-ID: <1473863952-7658-5-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1473863952-7658-1-git-send-email-yamada.masahiro@socionext.com>

Remove unneeded variables and assignments.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/gpu/drm/qxl/qxl_draw.c    | 7 ++-----
 drivers/gpu/drm/qxl/qxl_release.c | 7 ++-----
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/qxl/qxl_draw.c b/drivers/gpu/drm/qxl/qxl_draw.c
index ffe8853..9b728ed 100644
--- a/drivers/gpu/drm/qxl/qxl_draw.c
+++ b/drivers/gpu/drm/qxl/qxl_draw.c
@@ -57,11 +57,8 @@ static struct qxl_rect *drawable_set_clipping(struct qxl_device *qdev,
 static int
 alloc_drawable(struct qxl_device *qdev, struct qxl_release **release)
 {
-	int ret;
-	ret = qxl_alloc_release_reserved(qdev, sizeof(struct qxl_drawable),
-					 QXL_RELEASE_DRAWABLE, release,
-					 NULL);
-	return ret;
+	return qxl_alloc_release_reserved(qdev, sizeof(struct qxl_drawable),
+					  QXL_RELEASE_DRAWABLE, release, NULL);
 }
 
 static void
diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qxl_release.c
index f599cd0..cd83f05 100644
--- a/drivers/gpu/drm/qxl/qxl_release.c
+++ b/drivers/gpu/drm/qxl/qxl_release.c
@@ -203,12 +203,9 @@ static long qxl_fence_wait(struct fence *fence, bool intr, signed long timeout)
 static int qxl_release_bo_alloc(struct qxl_device *qdev,
 				struct qxl_bo **bo)
 {
-	int ret;
 	/* pin releases bo's they are too messy to evict */
-	ret = qxl_bo_create(qdev, PAGE_SIZE, false, true,
-			    QXL_GEM_DOMAIN_VRAM, NULL,
-			    bo);
-	return ret;
+	return qxl_bo_create(qdev, PAGE_SIZE, false, true,
+			     QXL_GEM_DOMAIN_VRAM, NULL, bo);
 }
 
 int qxl_release_list_add(struct qxl_release *release, struct qxl_bo *bo)
-- 
1.9.1

  parent reply	other threads:[~2016-09-14 14:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14 14:39 [PATCH v2 0/5] drm: clean up several " Masahiro Yamada
2016-09-14 14:39 ` [PATCH v2 1/5] drm/amdgpu: squash lines for simple " Masahiro Yamada
2016-09-15 14:45   ` Sean Paul
2016-09-14 14:39 ` [PATCH v2 2/5] drm/radeon: " Masahiro Yamada
2016-09-15 14:45   ` Sean Paul
2016-09-14 14:39 ` [PATCH v2 3/5] drm/bridge: " Masahiro Yamada
2016-09-15 13:51   ` Sean Paul
2016-09-15 14:46     ` Sean Paul
2016-09-16  1:41       ` Masahiro Yamada
2016-09-14 14:39 ` Masahiro Yamada [this message]
2016-09-15 12:30   ` [PATCH v2 4/5] drm/qxl: " Gustavo Padovan
2016-09-15 13:47   ` Gustavo Padovan
2016-09-15 14:45     ` Sean Paul
2016-09-14 14:39 ` [PATCH v2 5/5] drm/i915: use i915_gem_open() directly instead of i915_driver_open() Masahiro Yamada
2016-09-15  9:46   ` Jani Nikula
2016-09-15  9:48     ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473863952-7658-5-git-send-email-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=dan.carpenter@oracle.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fziglio@redhat.com \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®