From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763789AbcIOD1E (ORCPT ); Wed, 14 Sep 2016 23:27:04 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35109 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756775AbcIOD1C (ORCPT ); Wed, 14 Sep 2016 23:27:02 -0400 From: Wei Yongjun To: Jassi Brar Cc: Wei Yongjun , linux-kernel@vger.kernel.org Subject: [PATCH -next] mailbox: platform_mhu: Remove redundant dev_err call in platform_mhu_probe() Date: Thu, 15 Sep 2016 03:26:56 +0000 Message-Id: <1473910016-31107-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/mailbox/platform_mhu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mailbox/platform_mhu.c b/drivers/mailbox/platform_mhu.c index e13201a..b3b5acc 100644 --- a/drivers/mailbox/platform_mhu.c +++ b/drivers/mailbox/platform_mhu.c @@ -137,10 +137,8 @@ static int platform_mhu_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); mhu->base = devm_ioremap_resource(dev, res); - if (IS_ERR(mhu->base)) { - dev_err(dev, "ioremap failed\n"); + if (IS_ERR(mhu->base)) return PTR_ERR(mhu->base); - } for (i = 0; i < MHU_CHANS; i++) { mhu->chan[i].con_priv = &mhu->mlink[i];