From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933033AbcIOJQM (ORCPT ); Thu, 15 Sep 2016 05:16:12 -0400 Received: from mail-dm3nam03on0046.outbound.protection.outlook.com ([104.47.41.46]:4320 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757190AbcIOJQF (ORCPT ); Thu, 15 Sep 2016 05:16:05 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; From: Nava kishore Manne To: , , , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v2 3/3] tty: serial: xuartps: Wait for rx and tx reset done status Date: Thu, 15 Sep 2016 14:45:31 +0530 Message-ID: <1473930931-1034-3-git-send-email-navam@xilinx.com> X-Mailer: git-send-email 2.1.2 In-Reply-To: <1473930931-1034-1-git-send-email-navam@xilinx.com> References: <1473930931-1034-1-git-send-email-navam@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22578.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(6009001)(7916002)(2980300002)(438002)(199003)(189002)(90966002)(11100500001)(8936002)(50226002)(81156014)(4326007)(36756003)(8676002)(2950100001)(81166006)(4001450100002)(87936001)(5660300001)(4001430100002)(626004)(45336002)(46386002)(36386004)(50466002)(52956003)(48376002)(229853001)(103686003)(305945005)(42186005)(7846002)(2201001)(86362001)(50986999)(76176999)(63266004)(33646002)(356003)(5001770100001)(2906002)(586003)(47776003)(19580405001)(92566002)(19580395003)(5003940100001)(107886002)(189998001)(106466001)(107986001)(921003)(1121003)(83996005)(2101003)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR02MB2887;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM02FT051;1:1zZDNALgn8VFWmaM2XDrcD08iYCHKuhET5WNWtJUVbTFbZ3Kuet0HQGym5n5cSAP7zRnZ+r21YT9UVTpy4HKlmur58NAW3ZscY9BCgagBhLDGHLgsOKhsitCSXd4v3Fy7T9WysDsRRNRdJBnPsTQF518uLDZVLpBAWoGHkTuav6VfT8qVBVqgtPMDJ4tl2/wIR6yYBp3EKSM9qqgpVA4Wez8GjwJUqwVZ/wWLvOz2ey8WGlNCCEwG71kgE/j3ssg6LjTnOkXn8RyVei0lbvStp95NcVtBOUzH5JDoyIOe4sreCpieAV1Y6T7ElqrBdRhyFKEtZNzvA53fWEnd6BpS3CyJN1m2vL/FHRzq/1ek0UhcCcNU6YAp60X3wGWrD3o12Ntl66hECI4XQii9secbCNaezt2YAF5xIj3wdisHIZQEdhQtfSDq33ZCEh07PcutiFgv7v8oDkJ7dbt6uXLjJyqoS0uyzbxQHklilCfGrlvGy6PHV79+PEPD2/yn1xQD+j0o3XXOvhTfAhbyuroOm/BqWRwozsD3PaoDUWNmqEOO4ZLNxYVjXpg3iC8ZL/vfQDwLBbbanniop37V8nXzMoY/pefUObJsH+eRCQF4+PicJs0vEjqqT2Pxomt99rR MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 2bb2f452-1d40-4a54-996b-08d3dd48e412 X-Microsoft-Exchange-Diagnostics: 1;CY4PR02MB2887;2:XiAZGjVEsm4HPC8pU/A//wD/ux2wXUgJaJDFt7JE1Y7++1627I6QnHz2zj9iKl6N1i74Johi3rcMpncCfOc2+MezDDat8rX2Ansb5FZavQdBd4iR6D7ggIrMv72z677BrMTwNHTIkJ0kMldYYhcwNUx4PMUPg7iPHbrNwdhET0KDGW6r8k0y3ZEjRH99N0Tn;3:Mu866HHHLVSykPwDyMd2xxUpOaQvBmpYEnGxOqNxYFo4Qf47/UrL/8h1PKkVVmP6QK3nbY1fkzyAeXwhqBq5CxKpEwyacpM/xSxh4OIuRZnXkdFEtX5W2ZXbk4d0l66RgIwEqj3dDwCvzDzyIQaEoAibil/0xlLhFwpCFANjasbRNGaDAjin19T9Qob01kqK+g3FUZMKYtPCxVCEvC0xXN4uPwnPUoyDVDbuG5MoxNhnaVAbMyC4BBMnhTqYG2rxxYsNzJX9BB1M3EJVFJ70og==;25:hzV5eUPZcYJEpjTjF4hcBsLnQtpYWmWtRCnLLxnk6yI7WRx1NEjIfSUkJbKLV88KUGqrifg9umO170SJFmisyKaxtzXNy6sNHbd6JG1hBFhx0L1vKiWNLE7D8AOMh95Me7wDbxGIHGtaYv6yFUUGzsyK2zHO2Qt3Wgg+wcauPQvV+DunJ+U0srIa+eJmKaYvWRUeBV3tKHUpZPCKcEXHTWgvxmmrS0fu2Y2DnY1XqvJ+OL8JkZP9bQ/eiQKuOvRZ9z7trV96Nb7DaLHm4KqhzgonHPkwMnjdHnE8l2vjiH7t+CN6vEAhBzHhf3h0uA2qCBUOifGV0D5jattLHoX9m5XsvFX/do7piqB93ZEMa7sx5dAjmSALzzqSTHx5VlCqc7vu/3cEI/w6sv9ICPFs36/hzIL1GsDs/tMmKN60uag= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:CY4PR02MB2887; X-Microsoft-Exchange-Diagnostics: 1;CY4PR02MB2887;31:NlqwrVn9sQcMtDAFV3VMvZyL6/boeYSXFFBIFDqpltRE0fWxIyFTj7qdNCTL9IcuhftuRghQ31R/dH3sc1FPfDq0p0oYfPN7q8rmRl6hp0oIvkT+XR3JZomJ1eUDE0ouwtImyySrl2vCZGMlSXHjMOXiKm+w/B/nPReYdjzC2fGQr9hpf3je3rJAXNsa1s7y/2wzwUqtLf4sACs4zYhPjXixup2cp3lqLExJaHFV4Ik=;20:irhlmfXuyKYPmRKu+i8eJdKx9a+iW+HLEm3CCo87imZJwcZgAWsG7vLIAHqky7hjc1TsMmz12LppKeK+fnsdBjSOioLuO0rr3sGD2Fsjnf/Ewfnqo9P4+blRAlBwk+urwhnMv2cGZ+Bo9dmsiTzyNeLCFzbHtKy6VSFPNj4wa98EuDJrKfrufYCjlqx4Zeu5fAcJBEBvdhUPJUMWrazzgAT2i+CVzwVCEUMDAZggeBcNEF2+06rvMvjYeNwx9RIZXRiE+peNW+XEBBLvr9BIk56yD+0rDvAcN7CHgPXELqIf5gzws7s1XAKSDqitWrvwa9UtwCH0g9NZ9m+Cm3j1jL6hrhw8TBRNOfA0lVvU3EeTht/tnHNHiS93E8WUv9NQ2Omrgk2vG1Yhf1AbIROJZmjGkgq7uqHWSMQR18MCIKo3HlVGa7PAKimhahXKlb9cEXOffOF+W4lNgRuFjynZiBeIMVMeCBhlYqxGX4KT1Kqs3HByvdx7ZZypYPpBvWRB X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(13018025)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:CY4PR02MB2887;BCL:0;PCL:0;RULEID:;SRVR:CY4PR02MB2887; X-Microsoft-Exchange-Diagnostics: 1;CY4PR02MB2887;4:kuNnt475ocvp+S5DROGMGJkd/PuyuEb0aNkU1J6Yhlb2NNal9BlA6MKq1mV8TgWNhuFAOIDNJ8qgw5lD+SNyqsTp3FsacQnUT8blY/Y8QZxf2X4pL8+hiN/WJ9ia1jV7x9BwxBxLfc8nFk5zl7uRlhOlazUGnkp5jqAavYPvaPxVbnh7KqPD1fJwcFVyPuuk7f8qkKYSkUPEu9F50ue06gZTjMFV3hKXf7OxSZ0l19qNdgI+TBnvfXGIAlHUbgyOYmF+L+WR57o6H6pd3sPYB5qzvXSV6cnaK65OmDiAp1pzOo5q8WX1k5zHNKikcbpBhHfWCu7ZiUNFRajDXLnlK5PPZCAsRJVNiu9/JmeO9fARLLhrVcPIdJrs3UGErmPOsYAMOpOfnu8EEzueTyKRIrmnEgR29lWR2Gs58S4LU8BLiZiQv8On7jk36V7+As3p6S80hD57Y0UeUGstp4+bJrUVIoTj/pIpv5yMC9qpNKkL0SMuz8eSjIsZn1KblXV9X4VnSmfhKsDp/BTO9yix972Kx8yUpyLSELR0hTEMytY= X-Forefront-PRVS: 0066D63CE6 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR02MB2887;23:mcjjiati49k6B9uOTa5w992FYAcyL06BLUXRarGq4?= =?us-ascii?Q?M9HaYSpevUK9TZoQ9OZdaz2wCn1KEZvyb5v3caiOde9LyUOBWrB4uKZpLIMm?= =?us-ascii?Q?8jpBngUKOah2r8w0jQ+WHXewPp86POaSiJajH7dfxjVvmxvZUr+Cv+/a+o8n?= =?us-ascii?Q?zLXuALMEwnpMftqA8hm8t7q6RPq9gzQFXOp/2E7arFDYK6+bvawShf79TWuy?= =?us-ascii?Q?7XaLUAiX4d+zgmYqGHlmS2ecPsqm5WtARjYF7N2BlvS82SsH09nUTO3qzr1o?= =?us-ascii?Q?fE8oz7+Zf8fH+3YTrB9VvSpy8wZ3gZjQP1oxBiNsuNTqUNCaOw2pThmAKx7s?= =?us-ascii?Q?aXqQBOm9QuEZ/72lGoJCMgv1SqimLAkipqHwjxZz2p6Wo1RRdSAvcAPvaCyb?= =?us-ascii?Q?3rsAoBS2H3ZSMUH9uAi3WzQ6HdqK/8BYpMiw2++Oq7RVYkrHmJYuR93HJSzW?= =?us-ascii?Q?lj/7m5KjelClDQo1APNWt/WDKqwsN7bFz683w5DtsKlVnbqY4839lXXoT2Ap?= =?us-ascii?Q?c3/IGP68XKwU88ajUPRjr9o3Td6zUUARfO5B48CeDFqla4OcR8mIceJ2POzF?= =?us-ascii?Q?BB6ZSkUBJgE2xl8hx6qEozUYq1H0QQ0nwkRH7wT3nOazzWU9xwN7Kc9xjKfE?= =?us-ascii?Q?S+DHmh6jikLDU8YxHEA2EeSjRufYD3qQax/Yu5JOMnL0GjDI1dQmOiS4DXOO?= =?us-ascii?Q?6UYIqiHXXXvh7arpWQ8OqW87mFjNPE9+u3fmauJELZCBbXviZBf67wx5lh5p?= =?us-ascii?Q?24JStHoRv+wAwovlHxGcDYvtbv5WBE4SL3RlJyu8fvj3kXI5JlbA9WzOyr54?= =?us-ascii?Q?CrylWeEquIGpdj//18D3IiabiyU9zZiQySge6d+2dvpP6vXZcjfielu7knUP?= =?us-ascii?Q?hNyi9A9SH9vyILRirQ+5UNunBquw+GN/u2RTQMhydZ+ofsY36dGuVcL9LRz5?= =?us-ascii?Q?39/pXPZ87IBlUaCrKm+rHPGhu+9qitdD7C8K/6dCV7LqvJsNoDzPTvtkDLtG?= =?us-ascii?Q?CGSjqTVoYzomoe2PteXjMttv7ays+Bf/jglJVTYpHMxiCoQA8hxwhQH7OwgI?= =?us-ascii?Q?zLhSdboheBjO0yslBZCOhCaVTp/7GwXHjJT1TisJEOs9i6x7sxqDp/dSqpaL?= =?us-ascii?Q?YzoyVzYgQP3X5JfQDeK+6UsGXEH5Q/vDvWDSqU0KKdx2PqggQ6JJBkP8IVEp?= =?us-ascii?Q?K+BQgZRxxMj+JbaO14YqjmokkNQnmtfCA8MmpMtaqNB7FCeoQLQ4wAvj/ueq?= =?us-ascii?Q?iMVVq97SiN8M7AUzQi6b/lIdzB9hAvKl021ngpbha/Cqw+fZpTvSWZNskTHn?= =?us-ascii?Q?kIleu2RMTPsUpRU4gasssafTmujd3NuPmkwFnkvMraOStT6gR2/S6mBcLAIc?= =?us-ascii?Q?2Ej6Ggsk3mlL1UMRYWB2CNY1CWCsT2emxMaCScxLdjV6ewffemQuZiAsKuiC?= =?us-ascii?Q?ZBDHmjqgA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR02MB2887;6:B11RtttNulxhVDBumungF8/4KwOkFhw21P/WabkH3QmxB4GXIOs2qqUVz7DItUjq4IU9R+7ZmSdXCOURTusxPIDFDB0hO9WSorxTwDQcDoDE31mkrF7K7zRbKEbCNEXFS2OMe1+PwtKIstOJLNlZ3BQeFzWoTrzd52JAdZ6kspNv8mwISH1//Y14MmR6V8/IPs+2U1ln505uSoYQpUpUkjJvr7vMWQE3ke1M665PMvxNwVYihQQ7rYdkb38y4zQvCimmIsa0nn2R+la/cVzLMPOxN1h6I3b4e82ZWYkkv0L5yvBrbNpIBZNOIV2bvxYaWLGmEZrOJH05GwB0ypz7sQ==;5:yOzPC4kjZuStwvBfrv8XPMy9rgrE7y2YJXFJ7eRqnidBcIQzE1u7g82k4Lagp7uuU7NJLs5qdF4xXwOOUJoVhgQ0EmpXhzuLxWIpUAmF4jMe9jlESg072pAmodtYbpuM3LaZyIPHRJVlrN10zEQ5MA==;24:tL1wBtyQoMNFVESzM3LYd5+jINX45Fwufs70a4pli88cT/8gEa6STmaAsfAaJMX7fcvtwvF5lTcvTW0Z5qw/h/dq0RRrIG+rbvgAfjUcNnE=;7:j7iXFsmFp4+Pei0+k2Ne0bZZO6am4LOMsZ9n0uWNWISEOjWryQaQqrlahrX1SH/IQ8p5lLWHr5dZ6wYiF4MlknhoT2eFPFw2vKO5EBXJvrN7To2/9AoO2rqxKIb4b0ANTx2T9LNtr5Co794C9SeroGV/1Wn62M1nyNHVEDWVHcAb50ph+2xT9Rys5jiI+0HSVoHZNKrwJPwdJV+d1qHymcwwJfRBhk3V2SqcYV1VPAXMCJKiiZWP2z5D0RqWVCBX SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2016 09:15:51.9901 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB2887 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After issuing the reset, driver is not checking the rx and tx reset done status. So, modified driver to wait for the reset done status. Signed-off-by: Nava kishore Manne --- Changes for v2: -Added New patch drivers/tty/serial/xilinx_uartps.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 527526e..b69dea3 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -694,6 +694,10 @@ static void cdns_uart_set_termios(struct uart_port *port, ctrl_reg |= CDNS_UART_CR_TXRST | CDNS_UART_CR_RXRST; writel(ctrl_reg, port->membase + CDNS_UART_CR); + while (readl(port->membase + CDNS_UART_CR) & + (CDNS_UART_CR_TXRST | CDNS_UART_CR_RXRST)) + cpu_relax(); + /* * Clear the RX disable and TX disable bits and then set the TX enable * bit and RX enable bit to enable the transmitter and receiver. @@ -797,6 +801,10 @@ static int cdns_uart_startup(struct uart_port *port) writel(CDNS_UART_CR_TXRST | CDNS_UART_CR_RXRST, port->membase + CDNS_UART_CR); + while (readl(port->membase + CDNS_UART_CR) & + (CDNS_UART_CR_TXRST | CDNS_UART_CR_RXRST)) + cpu_relax(); + /* * Clear the RX disable bit and then set the RX enable bit to enable * the receiver. -- 2.1.2