From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764354AbcIOKMQ (ORCPT ); Thu, 15 Sep 2016 06:12:16 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:34087 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755893AbcIOKMO (ORCPT ); Thu, 15 Sep 2016 06:12:14 -0400 From: Wei Yongjun To: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, binoy.jayan@linaro.org, arnd@arndb.de, luisbg@osg.samsung.com, raphael.beamonte@gmail.com Cc: Wei Yongjun , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH -next] staging: rtl8712: fix double lock bug in SetPSModeWorkItemCallback() Date: Thu, 15 Sep 2016 10:12:05 +0000 Message-Id: <1473934325-7578-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun Fix a double lock bug in SetPSModeWorkItemCallback(). Fixes: 5c2ba8b85e35 ("rtl8712: pwrctrl_priv: Replace semaphore lock with mutex") Signed-off-by: Wei Yongjun --- drivers/staging/rtl8712/rtl871x_pwrctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl871x_pwrctrl.c b/drivers/staging/rtl8712/rtl871x_pwrctrl.c index 8f82d85..d464c13 100644 --- a/drivers/staging/rtl8712/rtl871x_pwrctrl.c +++ b/drivers/staging/rtl8712/rtl871x_pwrctrl.c @@ -145,7 +145,7 @@ static void SetPSModeWorkItemCallback(struct work_struct *work) mutex_lock(&pwrpriv->mutex_lock); if (pwrpriv->pwr_mode == PS_MODE_ACTIVE) r8712_set_rpwm(padapter, PS_STATE_S4); - mutex_lock(&pwrpriv->mutex_lock); + mutex_unlock(&pwrpriv->mutex_lock); } }