mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
To: <linux-kernel@vger.kernel.org>
Cc: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Subject: [PATCH v2 00/11] syscall/tracing: compat syscall support
Date: Fri, 16 Sep 2016 09:11:16 +0200	[thread overview]
Message-ID: <1474009887-7225-1-git-send-email-marcin.nowakowski@imgtec.com> (raw)

This patchset adds support syscall event tracing for compat syscalls.

Patch 1 removes the unnecessary syscall_nr field from syscall metadata,
which was one of the obstacles for adding proper support for compat syscalls.

Patch 2 adds a method to distinguish handling of syscalls for compat tasks
if an arch requires that. In disussions about an earlier version of these
patches (http://marc.info/?l=linux-mips&m=147259973128606&w=2) it was suggested
to use audit arch for detecting syscall type. After analysing the code
for various arches it seemed to me that this would add an unnecessary
complexity (as would require extra APIs to enumerate and map all audit
arch types) and I've just simply used compat task status to determine call
type. I cannot see any added value from using the audit arch type in this
context.

Patch 3 add compat syscall metadata - this is mostly a copy of a set of macros
for generating metadata for standard syscalls.

Further patches add arch-specific methods required for differentiating between
standard and compat syscalls as well as for finding syscall addresses from
inside syscall tables.

I have tried to keep the tracing system working for bisections - and most
things work as previously until arch-specific patch is applied. The only
exception here is x86 which had extra methods to prevent incorrect syscall
reporting for compat tasks - this may happen after patch 2 is applied and 
without x86/tracing patch.

Marcin Nowakowski (11):
  tracing/syscalls: remove syscall_nr from syscall metadata
  tracing/syscalls: add handling for compat tasks
  tracing/syscalls: add compat syscall metadata
  syscall/tracing: allow arch to override syscall_get_nr for ftrace
  x86/tracing: fix compat syscall handling
  s390/tracing: fix compat syscall handling
  arm64/tracing: fix compat syscall handling
  powerpc/tracing: fix compat syscall handling
  tile/tracing: fix compat syscall handling
  sparc/tracing: fix compat syscall handling
  parisc/tracing: fix compat syscall handling

 arch/arm64/include/asm/ftrace.h   |  12 +-
 arch/arm64/include/asm/unistd.h   |   1 +
 arch/arm64/kernel/Makefile        |   1 +
 arch/arm64/kernel/ftrace.c        |  16 +++
 arch/mips/kernel/ftrace.c         |   4 +-
 arch/parisc/include/asm/ftrace.h  |  10 ++
 arch/parisc/kernel/Makefile       |   1 +
 arch/parisc/kernel/ftrace.c       |  15 +++
 arch/powerpc/include/asm/ftrace.h |  26 +++-
 arch/powerpc/kernel/ftrace.c      |   6 +-
 arch/s390/include/asm/ftrace.h    |  11 ++
 arch/s390/include/asm/syscall.h   |   1 +
 arch/s390/kernel/Makefile         |   1 +
 arch/s390/kernel/ftrace.c         |  12 ++
 arch/sparc/include/asm/ftrace.h   |  10 ++
 arch/sparc/kernel/Makefile        |   1 +
 arch/sparc/kernel/ftrace.c        |  14 ++
 arch/tile/include/asm/ftrace.h    |  10 ++
 arch/tile/kernel/Makefile         |   1 +
 arch/tile/kernel/ftrace.c         |  13 ++
 arch/x86/include/asm/ftrace.h     |  14 +-
 arch/x86/include/asm/syscall.h    |   9 ++
 arch/x86/kernel/ftrace.c          |  15 +++
 include/linux/compat.h            |  74 +++++++++++
 include/linux/ftrace.h            |   2 +-
 include/linux/syscalls.h          |   1 -
 include/trace/syscall.h           |   2 -
 kernel/trace/trace.h              |  17 ++-
 kernel/trace/trace_syscalls.c     | 260 +++++++++++++++++++++++---------------
 29 files changed, 421 insertions(+), 139 deletions(-)

-- 
2.7.4

             reply	other threads:[~2016-09-16  7:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16  7:11 Marcin Nowakowski [this message]
2016-09-16  7:11 ` [PATCH v2 01/11] tracing/syscalls: remove syscall_nr from syscall metadata Marcin Nowakowski
2016-09-16  7:11 ` [PATCH v2 02/11] tracing/syscalls: add handling for compat tasks Marcin Nowakowski
2016-09-16  7:11 ` [PATCH v2 03/11] tracing/syscalls: add compat syscall metadata Marcin Nowakowski
2016-09-16  7:11 ` [PATCH v2 04/11] syscall/tracing: allow arch to override syscall_get_nr for ftrace Marcin Nowakowski
2016-09-16  7:11 ` [PATCH v2 05/11] x86/tracing: fix compat syscall handling Marcin Nowakowski
2016-09-16  7:11 ` [PATCH v2 06/11] s390/tracing: " Marcin Nowakowski
2016-09-16  7:11 ` [PATCH v2 07/11] arm64/tracing: " Marcin Nowakowski
2016-09-16  7:11 ` [PATCH v2 08/11] powerpc/tracing: " Marcin Nowakowski
2016-09-16  7:11 ` [PATCH v2 09/11] tile/tracing: " Marcin Nowakowski
2016-09-16 10:42   ` kbuild test robot
2016-09-20 18:49   ` Chris Metcalf
2016-09-16  7:11 ` [PATCH v2 10/11] sparc/tracing: " Marcin Nowakowski
2016-09-16  7:11 ` [PATCH v2 11/11] parisc/tracing: " Marcin Nowakowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474009887-7225-1-git-send-email-marcin.nowakowski@imgtec.com \
    --to=marcin.nowakowski@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®