From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758219AbcIPNEB (ORCPT ); Fri, 16 Sep 2016 09:04:01 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:32976 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbcIPNDy (ORCPT ); Fri, 16 Sep 2016 09:03:54 -0400 From: Wei Yongjun To: Alexandre Belloni , Boris Brezillon , Paul Gortmaker , Nicolas Ferre , Wei Yongjun Cc: Wei Yongjun , linux-kernel@vger.kernel.org Subject: [PATCH -next] memory: atmel-ebi: fix return value check in at91_ebi_dev_disable() Date: Fri, 16 Sep 2016 13:03:47 +0000 Message-Id: <1474031027-6785-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun Fix the retrn value check which testing the wrong variable in at91_ebi_dev_disable(). Signed-off-by: Wei Yongjun --- drivers/memory/atmel-ebi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c index b5ed3bd..047d6fc 100644 --- a/drivers/memory/atmel-ebi.c +++ b/drivers/memory/atmel-ebi.c @@ -657,7 +657,7 @@ static int at91_ebi_dev_disable(struct at91_ebi *ebi, struct device_node *np) return -ENOMEM; newprop->value = devm_kstrdup(dev, "disabled", GFP_KERNEL); - if (!newprop->name) + if (!newprop->value) return -ENOMEM; newprop->length = sizeof("disabled");