From: David Howells <dhowells@redhat.com>
To: netdev@vger.kernel.org
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next 12/14] rxrpc: Don't transmit an ACK if there's no reason set
Date: Sun, 18 Sep 2016 00:19:07 +0100 [thread overview]
Message-ID: <147415434767.17897.5111366020912850823.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <147415426459.17897.13899206413543061473.stgit@warthog.procyon.org.uk>
Don't transmit an ACK if call->ackr_reason in unset. There's the
possibility of a race between recvmsg() sending an ACK and the background
processing thread trying to send the same one.
Signed-off-by: David Howells <dhowells@redhat.com>
---
net/rxrpc/output.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c
index 06a9aca739d1..aa0507214b31 100644
--- a/net/rxrpc/output.c
+++ b/net/rxrpc/output.c
@@ -137,6 +137,11 @@ int rxrpc_send_call_packet(struct rxrpc_call *call, u8 type)
switch (type) {
case RXRPC_PACKET_TYPE_ACK:
spin_lock_bh(&call->lock);
+ if (!call->ackr_reason) {
+ spin_unlock_bh(&call->lock);
+ ret = 0;
+ goto out;
+ }
n = rxrpc_fill_out_ack(call, pkt);
call->ackr_reason = 0;
next prev parent reply other threads:[~2016-09-17 23:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 23:17 [PATCH net-next 00/14] rxrpc: Fixes & miscellany David Howells
2016-09-17 23:17 ` [PATCH net-next 01/14] rxrpc: Remove some whitespace David Howells
2016-09-17 23:17 ` [PATCH net-next 02/14] rxrpc: Move the check of rx_pkt_offset from rxrpc_locate_data() to caller David Howells
2016-09-17 23:18 ` [PATCH net-next 03/14] rxrpc: Check the return value of rxrpc_locate_data() David Howells
2016-09-17 23:18 ` [PATCH net-next 04/14] rxrpc: Fix handling of the last packet in rxrpc_recvmsg_data() David Howells
2016-09-17 23:18 ` [PATCH net-next 05/14] rxrpc: Record calls that need to be accepted David Howells
2016-09-17 23:18 ` [PATCH net-next 06/14] rxrpc: Purge the to_be_accepted queue on socket release David Howells
2016-09-17 23:18 ` [PATCH net-next 07/14] rxrpc: Fix the putting of client connections David Howells
2016-09-17 23:18 ` [PATCH net-next 08/14] rxrpc: Call rxrpc_release_call() on error in rxrpc_new_client_call() David Howells
2016-09-17 23:18 ` [PATCH net-next 09/14] rxrpc: Fix unexposed client conn release David Howells
2016-09-17 23:18 ` [PATCH net-next 10/14] rxrpc: Fix the parsing of soft-ACKs David Howells
2016-09-17 23:19 ` [PATCH net-next 11/14] rxrpc: Fix retransmission algorithm David Howells
2016-09-17 23:19 ` David Howells [this message]
2016-09-17 23:19 ` [PATCH net-next 13/14] rxrpc: Be consistent about switch value in rxrpc_send_call_packet() David Howells
2016-09-17 23:19 ` [PATCH net-next 14/14] rxrpc: Fix the basic transmit DATA packet content size at 1412 bytes David Howells
2016-09-18 11:22 ` [PATCH net-next 00/14] rxrpc: Fixes & miscellany David Miller
2016-09-19 5:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147415434767.17897.5111366020912850823.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®