From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758287AbcIRSCI (ORCPT ); Sun, 18 Sep 2016 14:02:08 -0400 Received: from conuserg-12.nifty.com ([210.131.2.79]:32428 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbcIRSCA (ORCPT ); Sun, 18 Sep 2016 14:02:00 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com u8II1HPS029538 X-Nifty-SrcIP: [111.169.71.157] From: Masahiro Yamada To: linux-m68k@vger.kernel.org Cc: Stephen Boyd , Ralf Baechle , Michael Turquette , Masahiro Yamada , Geert Uytterhoeven , Greg Ungerer , linux-kernel@vger.kernel.org Subject: [PATCH v4] m68k: let clk_disable() return immediately if clk is NULL Date: Mon, 19 Sep 2016 03:01:14 +0900 Message-Id: <1474221674-21625-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In many of clk_disable() implementations, it is a no-op for a NULL pointer input, but this is one of the exceptions. Making it treewide consistent will allow clock consumers to call clk_disable() without NULL pointer check. Signed-off-by: Masahiro Yamada Acked-by: Greg Ungerer --- Changes in v4: - Split into per-arch patches Changes in v3: - Return only when clk is NULL. Do not take care of error pointer. Changes in v2: - Rebase on Linux 4.6-rc1 arch/m68k/coldfire/clk.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/m68k/coldfire/clk.c b/arch/m68k/coldfire/clk.c index fddfdcc..1e3c7e9 100644 --- a/arch/m68k/coldfire/clk.c +++ b/arch/m68k/coldfire/clk.c @@ -101,6 +101,10 @@ EXPORT_SYMBOL(clk_enable); void clk_disable(struct clk *clk) { unsigned long flags; + + if (!clk) + return; + spin_lock_irqsave(&clk_lock, flags); if ((--clk->enabled == 0) && clk->clk_ops) clk->clk_ops->disable(clk); -- 1.9.1