From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758211AbcIRSGF (ORCPT ); Sun, 18 Sep 2016 14:06:05 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:43663 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757114AbcIRSF5 (ORCPT ); Sun, 18 Sep 2016 14:05:57 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com u8II4aDd017348 X-Nifty-SrcIP: [111.169.71.157] From: Masahiro Yamada To: Ralf Baechle , linux-mips@linux-mips.org Cc: Stephen Boyd , Michael Turquette , Masahiro Yamada , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , linux-arm-kernel@lists.infradead.org Subject: [PATCH v4] MIPS: bcm63xx: let clk_disable() return immediately if clk is NULL Date: Mon, 19 Sep 2016 03:04:35 +0900 Message-Id: <1474221875-22687-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In many of clk_disable() implementations, it is a no-op for a NULL pointer input, but this is one of the exceptions. Making it treewide consistent will allow clock consumers to call clk_disable() without NULL pointer check. Signed-off-by: Masahiro Yamada --- Changes in v4: - Split into per-arch patches Changes in v3: - Return only when clk is NULL. Do not take care of error pointer. Changes in v2: - Rebase on Linux 4.6-rc1 arch/mips/bcm63xx/clk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c index 6375652..b49fc9c 100644 --- a/arch/mips/bcm63xx/clk.c +++ b/arch/mips/bcm63xx/clk.c @@ -326,6 +326,9 @@ EXPORT_SYMBOL(clk_enable); void clk_disable(struct clk *clk) { + if (!clk) + return; + mutex_lock(&clocks_mutex); clk_disable_unlocked(clk); mutex_unlock(&clocks_mutex); -- 1.9.1