Re: [PATCH 1/3] x86: enable common clk on x86

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Monday, January 14, 2013 04:46:26 PM Mika Westerberg wrote:
> We are starting to see traditional SoC peripherals also in the x86 world,
> things like UART, I2C and SPI controllers that might already have a working
> device driver. These drivers typically take advantage of the Linux clk
> framework to control and retrieve information about the peripheral clock.
> 
> There hasn't been a standard way on x86 to pass the clock rate from
> whatever configuration system is used to the driver, but instead different
> variations have emerged, like adding this information to the platform data.
> 
> In order to use the standard Linux way we enable the common clk subsystem
> also on x86. This allows us to re-use the drivers with little or no
> modification wrt. clock API usage.
> 
> This patch was originally proposed by Mark Brown.

Are there any side effects of selecting COMMON_CLK by an arch and if so then
what are they?

Rafael


> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
>  arch/x86/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 79795af..decda04 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -114,6 +114,7 @@ config X86
>  	select MODULES_USE_ELF_RELA if X86_64
>  	select CLONE_BACKWARDS if X86_32
>  	select GENERIC_SIGALTSTACK
> +	select COMMON_CLK
>  
>  config INSTRUCTION_DECODER
>  	def_bool y
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.