From: Daniel Wagner <wagi@monom.org>
To: linux-cris-kernel@axis.com
Cc: Jesper Nilsson <jesper.nilsson@axis.com>,
Mikael Starvik <starvik@axis.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-kernel@vger.kernel.org,
Daniel Wagner <daniel.wagner@bmw-carit.de>
Subject: [PATCH 0/2] cris: fix a couple of incompatible pointer types
Date: Mon, 19 Sep 2016 08:27:55 +0200 [thread overview]
Message-ID: <1474266477-26090-1-git-send-email-wagi@monom.org> (raw)
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
Hi,
I got a love letter from kbuild about incompatible pointer types. I
added the new compiler flag [1] so it seems I am in charge cleaning up.
kbuild tells me:
All errors (new ones prefixed by >>):
arch/cris/arch-v32/mm/intmem.c: In function 'crisv32_intmem_free':
arch/cris/arch-v32/mm/intmem.c:116:14: warning: comparison of distinct pointer types lacks a cast
if ((prev != &intmem_allocations) &&
^~
arch/cris/arch-v32/mm/intmem.c:123:14: warning: comparison of distinct pointer types lacks a cast
if ((next != &intmem_allocations) &&
^~
In file included from include/linux/printk.h:5:0,
from include/linux/kernel.h:13,
from include/linux/list.h:8,
from arch/cris/arch-v32/mm/intmem.c:7:
arch/cris/arch-v32/mm/intmem.c: At top level:
>> arch/cris/arch-v32/mm/intmem.c:148:17: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
device_initcall(crisv32_intmem_init);
^
include/linux/init.h:184:58: note: in definition of macro '__define_initcall'
__attribute__((__section__(".initcall" #id ".init"))) = fn; \
^~
arch/cris/arch-v32/mm/intmem.c:148:1: note: in expansion of macro 'device_initcall'
device_initcall(crisv32_intmem_init);
^~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
cheers,
daniel
[1] ea8daa7b9784 ("kbuild: Add option to turn incompatible pointer check
into error")
Daniel Wagner (2):
cris: don't compare incompatible pointer type
cris: use correct device_init() function signature
arch/cris/arch-v32/mm/intmem.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
--
2.7.4
next reply other threads:[~2016-09-19 6:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 6:27 Daniel Wagner [this message]
2016-09-19 6:27 ` [PATCH 1/2] cris: don't compare incompatible pointer type Daniel Wagner
2016-09-19 6:27 ` [PATCH 2/2] cris: use correct device_init() function signature Daniel Wagner
2016-09-19 6:59 ` [PATCH 0/2] cris: fix a couple of incompatible pointer types Niklas Cassel
2016-09-19 7:08 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474266477-26090-1-git-send-email-wagi@monom.org \
--to=wagi@monom.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=jesper.nilsson@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®