From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938775AbcISIXr (ORCPT ); Mon, 19 Sep 2016 04:23:47 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:38537 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938550AbcISIXG (ORCPT ); Mon, 19 Sep 2016 04:23:06 -0400 X-AuditID: cbfee61a-f78ff6d000001462-b2-57dfa067d5b6 From: Jacek Anaszewski To: linux-leds@vger.kernel.org Cc: linux-kernel@vger.kernel.org, greg@kroah.com, Jacek Anaszewski , Jacek Anaszewski Subject: [PATCH] leds: triggers: Check return value of kobject_uevent_env() Date: Mon, 19 Sep 2016 10:22:51 +0200 Message-id: <1474273371-6535-1-git-send-email-j.anaszewski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPJMWRmVeSWpSXmKPExsVy+t9jQd30BffDDZYeM7A4t2AGo0Xv1eeM Fre3bmCxuLxrDpvF1jfrGB1YPXbOusvu8fZhgEffllWMHp83yQWwRHHZpKTmZJalFunbJXBl NDVvZy64zFax+89dlgbG86xdjJwcEgImEl/XbYCyxSQu3FvP1sXIxSEkMItR4uLBTawQzk9G iTl/brKDVLEJGEr8fPGaqYuRg0NEQE5i55lKkBpmgQmMEs13V7CA1AgLeEtca5zIBmKzCKhK rNl6hwnE5hVwl2jfO5MZYpucxMljk1knMHIvYGRYxSiRWpBcUJyUnmuYl1quV5yYW1yal66X nJ+7iREcDM+kdjAe3OV+iFGAg1GJh/dDz/1wIdbEsuLK3EOMEhzMSiK83+cChXhTEiurUovy 44tKc1KLDzFKc7AoifM+/r8uTEggPbEkNTs1tSC1CCbLxMEp1cAY0pPaMmfOP6GX+9a7lM5l WVBtfdN3d5aKxBvpzZsOrVTqdCo/9vQXr/Klngam2R+nHNy9JSPerfBlbwL7igdz13y1ainS Or71hubqn186BA2eOl+XTbk+10HmUN1l1uWvn4i4GGo/cpzwOPrkh8zNnytEj5p73OiNvci5 wVZecstRJ6Ek5/VxSizFGYmGWsxFxYkA3YzpMwICAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jacek Anaszewski Log error message if kobject_uevent_env() fails in led_trigger_set(). Signed-off-by: Jacek Anaszewski --- drivers/leds/led-triggers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c index c7a38d4..f538e8c 100644 --- a/drivers/leds/led-triggers.c +++ b/drivers/leds/led-triggers.c @@ -141,7 +141,8 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig) if (event) { envp[0] = event; envp[1] = NULL; - kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp); + if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp)) + pr_err("Error sending uevent after setting LED trigger\n"); kfree(event); } } -- 1.9.1