From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757915AbcISKFu (ORCPT ); Mon, 19 Sep 2016 06:05:50 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:39441 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755093AbcISKFo (ORCPT ); Mon, 19 Sep 2016 06:05:44 -0400 X-AuditID: cbfee61b-f79466d000001e3c-3b-57dfb8769d92 From: Jacek Anaszewski To: linux-leds@vger.kernel.org Cc: linux-kernel@vger.kernel.org, greg@kroah.com, Jacek Anaszewski Subject: [PATCH v2] leds: triggers: Check return value of kobject_uevent_env() Date: Mon, 19 Sep 2016 12:05:34 +0200 Message-id: <1474279534-30204-1-git-send-email-j.anaszewski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCJMWRmVeSWpSXmKPExsVy+t9jAd2yHffDDW7+4LM4t2AGo0Xv1eeM Fpd3zWGz2PpmHaMDi8fbhwEefVtWMXp83iQXwBzFZZOSmpNZllqkb5fAlfF06l+Wgo9sFT+O 9TE2MD5i7WLk5JAQMJF4OPMOM4QtJnHh3nq2LkYuDiGBpYwSp1fMhHJ+MkpsWfaDEaSKTcBQ 4ueL10xdjBwcIgJyEjvPVIKEmQXiJf7/+cICYgsL+Ek8WNsANpRFQFXi5p0zYDavgIfEzraD TBDL5CROHpvMOoGRewEjwypGidSC5ILipPRco7zUcr3ixNzi0rx0veT83E2MYL8/k97BeHiX +yFGAQ5GJR7eA0n3w4VYE8uKK3MPMUpwMCuJ8NZsBgrxpiRWVqUW5ccXleakFh9ilOZgURLn ffx/XZiQQHpiSWp2ampBahFMlomDU6qB0d8j0TjXLupZnveC+WtX7HgmcHHL/rDVuzcV8/Uc C86f3nLL8SWv5ulOR875Uem70oP/5h/Ud69cvfL6jUieo/+X7E3am2K6zTwkWld1SwZr5Rq/ ypyYzVP/ZHVLMbhfSN5ffDPkb5zjiw/H5Kdsi54mlPgvsVPu5cK1wicWfbzGZlR5oni1gRJL cUaioRZzUXEiADsxlQD3AQAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Log error message if kobject_uevent_env() fails in led_trigger_set(). Signed-off-by: Jacek Anaszewski --- Changes from v1: - switched to using dev_err() instead of pr_err() drivers/leds/led-triggers.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c index c7a38d4..26b3db1 100644 --- a/drivers/leds/led-triggers.c +++ b/drivers/leds/led-triggers.c @@ -141,7 +141,9 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig) if (event) { envp[0] = event; envp[1] = NULL; - kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp); + if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp)) + dev_err(led_cdev->dev, + "led_trigger_set: Error sending uevent\n"); kfree(event); } } -- 1.9.1