From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757751AbcISKTU (ORCPT ); Mon, 19 Sep 2016 06:19:20 -0400 Received: from smtprelay0027.hostedemail.com ([216.40.44.27]:50955 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752711AbcISKTN (ORCPT ); Mon, 19 Sep 2016 06:19:13 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:4321:5007:10004:10400:10848:11026:11232:11658:11914:12043:12114:12296:12740:13069:13095:13161:13229:13311:13357:13439:13894:14659:14721:21080:21433:21451:30012:30029:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: judge01_33252da5c0c58 X-Filterd-Recvd-Size: 1669 Message-ID: <1474280350.1954.20.camel@perches.com> Subject: Re: [PATCH v2] leds: triggers: Check return value of kobject_uevent_env() From: Joe Perches To: Jacek Anaszewski , linux-leds@vger.kernel.org Cc: linux-kernel@vger.kernel.org, greg@kroah.com Date: Mon, 19 Sep 2016 03:19:10 -0700 In-Reply-To: <1474279534-30204-1-git-send-email-j.anaszewski@samsung.com> References: <1474279534-30204-1-git-send-email-j.anaszewski@samsung.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-09-19 at 12:05 +0200, Jacek Anaszewski wrote: > Log error message if kobject_uevent_env() fails in led_trigger_set(). trivia: > diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c [] > @@ -141,7 +141,9 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig) >   if (event) { >   envp[0] = event; >   envp[1] = NULL; > - kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp); > + if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp)) > + dev_err(led_cdev->dev, > + "led_trigger_set: Error sending uevent\n"); It is generally better to use %s, __func__ than to embed a function name in the format string. + dev_err(led_cdev->dev, "%s: Error sending uevent\n", + __func__); Then Function renaming and code refactoring is less error prone.