From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1761814AbcISKca (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Sep 2016 06:32:30 -0400
Received: from smtprelay0158.hostedemail.com ([216.40.44.158]:35925 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1759139AbcISKcT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Sep 2016 06:32:19 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:560:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2731:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3872:4250:4321:5007:10004:10400:10848:11026:11232:11473:11658:11914:12043:12438:12740:13069:13311:13357:13439:13894:14659:14721:21080:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: ant90_13ef1e0737856
X-Filterd-Recvd-Size: 2043
Message-ID: <1474281135.1954.22.camel@perches.com>
Subject: Re: [PATCH 05/15] usb: chipidea: imx: Change switch order
From: Joe Perches <joe@perches.com>
To: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>,
        hzpeterchen@gmail.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Mon, 19 Sep 2016 03:32:15 -0700
In-Reply-To: <1474280295-17503-1-git-send-email-fabien.lahoudere@collabora.co.uk>
References: <1474280295-17503-1-git-send-email-fabien.lahoudere@collabora.co.uk>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.21.91-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2016-09-19 at 12:18 +0200, Fabien Lahoudere wrote:
> Each USB controller have different behaviour, so in order to avoid to have
> several "swicth(data->index)" and lock/unlock, we prefer to get the index
> and then test for features if they exist for this index.
[]
> diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
[]
> @@ -199,31 +199,45 @@ static int usbmisc_imx53_init(struct imx_usbmisc_data *data)
> 	val |= MX53_USB_PLL_DIV_24_MHZ;
> 	writel(val, usbmisc->base + MX53_USB_OTG_PHY_CTRL_1_OFFSET);
>  
> -	if (data->disable_oc) {
> -		spin_lock_irqsave(&usbmisc->lock, flags);
> -		switch (data->index) {
> +	spin_lock_irqsave(&usbmisc->lock, flags);
> +
> +	switch (data->index) {
> 		case 0:
> -			reg = usbmisc->base + MX53_USB_OTG_PHY_CTRL_0_OFFSET;
> -			val = readl(reg) | MX53_BM_OVER_CUR_DIS_OTG;
> +			if (data->disable_oc) {
> +				reg = usbmisc->base + MX53_USB_OTG_PHY_CTRL_0_OFFSET;
> +				val = readl(reg) | MX53_BM_OVER_CUR_DIS_OTG;
> +				if (reg && val)
> +					writel(val, reg);
> +			}
> 			break;

It'd be nicer to unindent the switches case blocks one level too.

	switch (case->index){
	case 0:
		etc...