From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754819AbcISKwq (ORCPT ); Mon, 19 Sep 2016 06:52:46 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:53411 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725AbcISKwj (ORCPT ); Mon, 19 Sep 2016 06:52:39 -0400 X-AuditID: cbfee61b-f79466d000001e3c-07-57dfc374a516 From: Jacek Anaszewski To: linux-leds@vger.kernel.org Cc: linux-kernel@vger.kernel.org, greg@kroah.com, joe@perches.com, Jacek Anaszewski Subject: [PATCH v3] leds: triggers: Check return value of kobject_uevent_env() Date: Mon, 19 Sep 2016 12:52:24 +0200 Message-id: <1474282344-11496-1-git-send-email-j.anaszewski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLJMWRmVeSWpSXmKPExsVy+t9jAd3Sw/fDDXqPM1qcWzCD0aL36nNG i9n3H7NYXN41h81i65t1jA6sHm8fBnh8WXWN2aNvyypGj8+b5AJYorhsUlJzMstSi/TtErgy Hn7dzlzwkL2i8ZxyA+Nuti5GTg4JAROJp1N6WCBsMYkL99YDxbk4hASWMkosaXnHBOH8ZJTY e+oJO0gVm4ChxM8Xr4ESHBwiAnISO89UgoSZBQokzs9ewQhiCwv4STx9uhdsAYuAqsSeLbdY QWxeAQ+JR1N2MEEsk5M4eWwy6wRG7gWMDKsYJVILkguKk9JzjfJSy/WKE3OLS/PS9ZLzczcx ggPhmfQOxsO73A8xCnAwKvHwHki6Hy7EmlhWXJl7iFGCg1lJhPfpHqAQb0piZVVqUX58UWlO avEhRmkOFiVx3sf/14UJCaQnlqRmp6YWpBbBZJk4OKUaGEs03RXOFeQ+v2sR0JaRvrW3m/XB K04lv1VH2qvVZ4oXZV8Pl7V+FL5rY0mjYffOkrBZPSlMDdLSVit7uzW25Rv3RXK+zlsTXeW1 +TZL3dy979OXWOs7p72SY/J+xzNPcHe5cJLlK6fjF3vmXvfMT2wJOXi5pcBq1qYP5kVzTkZ0 Wk/fEOqqxFKckWioxVxUnAgAwFqxMwACAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Log error message if kobject_uevent_env() fails in led_trigger_set(). Signed-off-by: Jacek Anaszewski --- Changes from v1: - switched to using dev_err() instead of pr_err() Changes from v2: - switched to using __func__ instead of explicit function name, to simplify code maintenance drivers/leds/led-triggers.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c index c7a38d4..431123b 100644 --- a/drivers/leds/led-triggers.c +++ b/drivers/leds/led-triggers.c @@ -141,7 +141,9 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig) if (event) { envp[0] = event; envp[1] = NULL; - kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp); + if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp)) + dev_err(led_cdev->dev, + "%s: Error sending uevent\n", __func__); kfree(event); } } -- 1.9.1