From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756994AbcIVNkb (ORCPT ); Thu, 22 Sep 2016 09:40:31 -0400 Received: from atlantic540.startdedicated.de ([188.138.9.77]:44265 "EHLO atlantic540.startdedicated.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752275AbcIVNk3 (ORCPT ); Thu, 22 Sep 2016 09:40:29 -0400 From: Daniel Wagner To: linux-kernel@vger.kernel.org Cc: Daniel Wagner , Lee Jones Subject: [PATCH] mfd: mc13xxx-core: use complete() instead complete_all() Date: Thu, 22 Sep 2016 15:40:22 +0200 Message-Id: <1474551622-27331-1-git-send-email-wagi@monom.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Wagner There is only one waiter for the completion, therefore there is no need to use complete_all(). Let's make that clear by using complete() instead of complete_all(). The usage pattern of the completion is: waiter context waker context mc13xxx_adc_do_conversion() struct mc13xxx_adcdone_data adcdone_data init_completion(&adcdone_data.done) mc13xxx_irq_request() wait_for_completeion_interruptible() mc13xxx_handler_adcdone() complete() Signed-off-by: Daniel Wagner Cc: Lee Jones --- drivers/mfd/mc13xxx-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c index d7f54e4..af23115 100644 --- a/drivers/mfd/mc13xxx-core.c +++ b/drivers/mfd/mc13xxx-core.c @@ -245,7 +245,7 @@ static irqreturn_t mc13xxx_handler_adcdone(int irq, void *data) { struct mc13xxx_adcdone_data *adcdone_data = data; - complete_all(&adcdone_data->done); + complete(&adcdone_data->done); return IRQ_HANDLED; } -- 2.7.4