From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933808AbcIVOJv (ORCPT ); Thu, 22 Sep 2016 10:09:51 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:33186 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755105AbcIVOJt (ORCPT ); Thu, 22 Sep 2016 10:09:49 -0400 From: Arvind Yadav To: daniel.lezcano@linaro.org, tglx@linutronix.de, vincent.guittot@linaro.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc Date: Thu, 22 Sep 2016 19:39:26 +0530 Message-Id: <1474553366-8400-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Free memory and memory mapping, if mxc_timer_init_dt is not successful. Signed-off-by: Arvind Yadav --- drivers/clocksource/timer-imx-gpt.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c index f595460..19f6860 100644 --- a/drivers/clocksource/timer-imx-gpt.c +++ b/drivers/clocksource/timer-imx-gpt.c @@ -489,12 +489,17 @@ static int __init mxc_timer_init_dt(struct device_node *np, enum imx_gpt_type t return -ENOMEM; imxtm->base = of_iomap(np, 0); - if (!imxtm->base) + if (!imxtm->base) { + kfree(imxtm); return -ENXIO; + } imxtm->irq = irq_of_parse_and_map(np, 0); - if (imxtm->irq <= 0) + if (imxtm->irq <= 0) { + iounmap(imxtm->base); + kfree(imxtm); return -EINVAL; + } imxtm->clk_ipg = of_clk_get_by_name(np, "ipg"); @@ -506,8 +511,11 @@ static int __init mxc_timer_init_dt(struct device_node *np, enum imx_gpt_type t imxtm->type = type; ret = _mxc_timer_init(imxtm); - if (ret) + if (ret) { + iounmap(imxtm->base); + kfree(imxtm); return ret; + } initialized = 1; -- 2.7.4