From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934876AbcIVQtp (ORCPT ); Thu, 22 Sep 2016 12:49:45 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:33396 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757428AbcIVQto (ORCPT ); Thu, 22 Sep 2016 12:49:44 -0400 Message-ID: <1474562982.23058.140.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH v2] fs/select: add vmalloc fallback for select(2) From: Eric Dumazet To: Vlastimil Babka Cc: Alexander Viro , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , netdev@vger.kernel.org Date: Thu, 22 Sep 2016 09:49:42 -0700 In-Reply-To: <20160922164359.9035-1-vbabka@suse.cz> References: <20160922164359.9035-1-vbabka@suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-09-22 at 18:43 +0200, Vlastimil Babka wrote: > The select(2) syscall performs a kmalloc(size, GFP_KERNEL) where size grows > with the number of fds passed. We had a customer report page allocation > failures of order-4 for this allocation. This is a costly order, so it might > easily fail, as the VM expects such allocation to have a lower-order fallback. > > Such trivial fallback is vmalloc(), as the memory doesn't have to be > physically contiguous. Also the allocation is temporary for the duration of the > syscall, so it's unlikely to stress vmalloc too much. vmalloc() uses a vmap_area_lock spinlock, and TLB flushes. So I guess allowing vmalloc() being called from an innocent application doing a select() might be dangerous, especially if this select() happens thousands of time per second.