From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935160AbcIVTlD (ORCPT ); Thu, 22 Sep 2016 15:41:03 -0400 Received: from mga14.intel.com ([192.55.52.115]:65320 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933053AbcIVTlB (ORCPT ); Thu, 22 Sep 2016 15:41:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,379,1470726000"; d="scan'208";a="1034852910" Message-ID: <1474573259.3916.199.camel@linux.intel.com> Subject: Re: [PATCH v4 07/10] x86/sched: Add SD_ASYM_PACKING flags to x86 ITMT CPU From: Tim Chen To: "Rafael J. Wysocki" , Srinivas Pandruvada Cc: "Rafael J. Wysocki" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , the arch/x86 maintainers , Linux PM , Linux Kernel Mailing List , ACPI Devel Maling List , Peter Zijlstra , jolsa@redhat.com Date: Thu, 22 Sep 2016 12:40:59 -0700 In-Reply-To: References: <1474485552-141429-1-git-send-email-srinivas.pandruvada@linux.intel.com> <1474485552-141429-8-git-send-email-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-09-21 at 22:33 +0200, Rafael J. Wysocki wrote: > On Wed, Sep 21, 2016 at 9:19 PM, Srinivas Pandruvada > wrote: > > > > From: Tim Chen > > > > Some Intel cores in a package can be boosted to a higher turbo frequency > > with ITMT 3.0 technology. The scheduler can use the asymmetric packing > > feature to move tasks to the more capable cores. > > > > If ITMT is enabled, add SD_ASYM_PACKING flag to the thread and core > > sched domains to enable asymmetric packing. > > > > Signed-off-by: Tim Chen > > Signed-off-by: Peter Zijlstra (Intel) > > Signed-off-by: Srinivas Pandruvada > > --- > >  arch/x86/kernel/smpboot.c | 27 +++++++++++++++++++++++---- > >  1 file changed, 23 insertions(+), 4 deletions(-) > > > > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c > > index 38901b3..46815e6 100644 > > --- a/arch/x86/kernel/smpboot.c > > +++ b/arch/x86/kernel/smpboot.c > > @@ -487,22 +487,41 @@ static bool match_die(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o) > >         return false; > >  } > > > > +#ifndef CONFIG_SCHED_ITMT > > +#define sysctl_sched_itmt_enabled      0 > > +#endif > I thought that would be done in the header where > sysctl_sched_itmt_enabled is declared (along with defining the stubs > for the sched_set_itmt_* functions). Sure. I will move it to arch/x86/include/asm/topology.h. Tim