From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Andi Kleen <andi@firstfloor.org>, David Ahern <dsahern@gmail.com>,
Don Zickus <dzickus@redhat.com>, Joe Mario <jmario@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 09/15] perf hists: Add __hist_entry__snprintf function
Date: Thu, 22 Sep 2016 18:12:53 -0300 [thread overview]
Message-ID: <1474578779-14095-10-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1474578779-14095-1-git-send-email-acme@kernel.org>
From: Jiri Olsa <jolsa@kernel.org>
Add __hist_entry__snprintf() to take a perf_hpp_list as an argument
instead of using he->hists->hpp_list.
This way we can display arbitrary list of entries regardless of the
hists setup, which will be useful in the upcoming c2c patch series.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1474558645-19956-2-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/ui/stdio/hist.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c
index c8dca34585ea..189665c315cc 100644
--- a/tools/perf/ui/stdio/hist.c
+++ b/tools/perf/ui/stdio/hist.c
@@ -373,7 +373,8 @@ static size_t hist_entry_callchain__fprintf(struct hist_entry *he,
return 0;
}
-static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
+static int __hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp,
+ struct perf_hpp_list *hpp_list)
{
const char *sep = symbol_conf.field_sep;
struct perf_hpp_fmt *fmt;
@@ -384,7 +385,7 @@ static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
if (symbol_conf.exclude_other && !he->parent)
return 0;
- hists__for_each_format(he->hists, fmt) {
+ perf_hpp_list__for_each_format(hpp_list, fmt) {
if (perf_hpp__should_skip(fmt, he->hists))
continue;
@@ -410,6 +411,11 @@ static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
return hpp->buf - start;
}
+static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
+{
+ return __hist_entry__snprintf(he, hpp, he->hists->hpp_list);
+}
+
static int hist_entry__hierarchy_fprintf(struct hist_entry *he,
struct perf_hpp *hpp,
struct hists *hists,
--
2.7.4
next prev parent reply other threads:[~2016-09-22 21:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 21:12 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-09-22 21:12 ` [PATCH 01/15] perf evsel: Remove superfluous initialization of weight Arnaldo Carvalho de Melo
2016-09-22 21:12 ` [PATCH 02/15] perf hists: Use bigger buffer for stdio headers Arnaldo Carvalho de Melo
2016-09-22 21:12 ` [PATCH 03/15] perf tools: Confine __get_cpuid() to x86 architecture Arnaldo Carvalho de Melo
2016-09-22 21:12 ` [PATCH 04/15] perf tools: Make coresight PMU listable Arnaldo Carvalho de Melo
2016-09-22 21:12 ` [PATCH 05/15] perf tools: Add coresight etm PMU record capabilities Arnaldo Carvalho de Melo
2016-09-22 21:12 ` [PATCH 06/15] perf pmu: Push configuration down to PMU driver Arnaldo Carvalho de Melo
2016-09-22 21:12 ` [PATCH 07/15] perf tools: Add PMU configuration to tools Arnaldo Carvalho de Melo
2016-09-22 21:12 ` [PATCH 08/15] perf tools: Add sink configuration for cs_etm PMU Arnaldo Carvalho de Melo
2016-09-22 21:12 ` Arnaldo Carvalho de Melo [this message]
2016-09-22 21:12 ` [PATCH 10/15] perf tools: Make reset_dimensions global Arnaldo Carvalho de Melo
2016-09-22 21:12 ` [PATCH 11/15] perf tools: Make output_field_add and sort_dimension__add global Arnaldo Carvalho de Melo
2016-09-22 21:12 ` [PATCH 12/15] perf tools: Make several sorting functions global Arnaldo Carvalho de Melo
2016-09-22 21:12 ` [PATCH 13/15] perf tools: Make several display " Arnaldo Carvalho de Melo
2016-09-22 21:12 ` [PATCH 14/15] perf hists: Make __hist_entry__snprintf function global Arnaldo Carvalho de Melo
2016-09-22 21:12 ` [PATCH 15/15] perf hists: Make hists__fprintf_headers " Arnaldo Carvalho de Melo
2016-09-23 5:22 ` [GIT PULL 00/15] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474578779-14095-10-git-send-email-acme@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=jmario@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome