From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1030207AbcIWJHg (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Sep 2016 05:07:36 -0400
Received: from slow1-d.mail.gandi.net ([217.70.178.86]:50494 "EHLO
        slow1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965614AbcIWJHc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Sep 2016 05:07:32 -0400
X-Originating-IP: 83.155.44.161
Message-ID: <1474621394.10437.19.camel@hadess.net>
Subject: Re: [PATCH] ASoC: tlv320aic31xx: add explicit support for
 tlv320dac31xx
From: Bastien Nocera <hadess@hadess.net>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Jyri Sarha <jsarha@ti.com>, Peter Ujfalusi <peter.ujfalusi@ti.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: Chris Healy <cphealy@gmail.com>
Date: Fri, 23 Sep 2016 11:03:14 +0200
In-Reply-To: <1474574803-4007-1-git-send-email-nikita.yoush@cogentembedded.com>
References: <1474574803-4007-1-git-send-email-nikita.yoush@cogentembedded.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.21.92 (3.21.92-1.fc25) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2016-09-22 at 23:06 +0300, Nikita Yushchenko wrote:
> tlv320dac31xx is a subset of tlv320aic31xx:
> - it does not have MIC inputs and ADC, thus capture is not supported,
> - it has analog inputs AIN1/AIN2 that can be mixed into output.
> 
> Although tlv320dac31xx does work with tlv320aic31xx driver, this
> setup
> does register non-existent widgets and non-existent capture stream.
> Thus userspace lists non-existent objects in user interfaces, an can
> access these, causing operations with device registers that are
> declared as "reserved" in tlv320dac31xx datasheet.
> 
> This patch fixes this situation by separating controls/widgets/routes
> into common, aic31xx-specific, and dac31xx-specific parts. Only parts
> that match actual hardware (as declared in "compatible" device tree
> property) are registered.
> 
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>

I don't have access to the hardware. My original patch allowed playback
to work (ish) on a specific device that I don't own. Probably best to
ignore my patch, or even revert it before applying this one.

Cheers