From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941227AbcIYX6F (ORCPT ); Sun, 25 Sep 2016 19:58:05 -0400 Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:42600 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756616AbcIYX6E (ORCPT ); Sun, 25 Sep 2016 19:58:04 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AusZAO5j6Fd5LJiaEGdsb2JhbABdHAEBBAEBCgEBgzsBAQEBAR6BU4MCg3GcSgEBAQEBB5B6gi6LcU0BAgEBAQEBAgYBAQEBAQEBATdAhHQXDwEjIxgBFwUCJgI7AwctiEqUJJ0mjHiBBoRnhloBg1OCOIJaBZl2j2qPZwJIkB+DHVANDxiBSiw0h1gBAQE From: Dave Chinner To: linux-kernel@vger.kernel.org Cc: viro@zeniv.linux.org.uk, torvalds@linux-foundation.org Subject: [PATCH] [4.8-rc7, regression] fault_in_multipages_readable() throws set-but-unused error Date: Mon, 26 Sep 2016 09:57:33 +1000 Message-Id: <1474847853-9668-1-git-send-email-david@fromorbit.com> X-Mailer: git-send-email 2.8.0.rc3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Chinner When building XFS with -Werror, it now fails with: ./include/linux/pagemap.h: In function ¿fault_in_multipages_readable¿: ./include/linux/pagemap.h:602:16: error: variable ¿c¿ set but not used [-Werror=unused-but-set-variable] volatile char c; ^ This is a regression caused by commit e23d415 ("fix fault_in_multipages_...() on architectures with no-op access_ok()"). Fix it by re-adding the "(void)c" trick taht was previously used to make the compiler think the variable is used. Signed-off-by: Dave Chinner --- include/linux/pagemap.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 7e3d537..01e8443 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -620,6 +620,7 @@ static inline int fault_in_multipages_readable(const char __user *uaddr, return __get_user(c, end); } + (void)c; return 0; } -- 2.8.0.rc3