From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941308AbcIZHgz (ORCPT ); Mon, 26 Sep 2016 03:36:55 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:47698 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932592AbcIZHgy (ORCPT ); Mon, 26 Sep 2016 03:36:54 -0400 From: Bob Liu To: xen-devel@lists.xenproject.org Cc: roger.pau@citrix.com, konrad.wilk@oracle.com, linux-kernel@vger.kernel.org, Bob Liu Subject: [PATCH] block: xen-blkback: don't get/put blkif ref for each queue Date: Mon, 26 Sep 2016 15:36:24 +0800 Message-Id: <1474875384-24671-1-git-send-email-bob.liu@oracle.com> X-Mailer: git-send-email 1.7.10.4 X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org xen_blkif_get/put() for each queue is useless, and introduces a bug: If there is I/O inflight when removing device, xen_blkif_disconnect() will return -EBUSY and xen_blkif_put() not be called. Which means the references are leaked, then even if I/O completed, the xen_blkif_put() won't call xen_blkif_deferred_free() to free resources anymore. Signed-off-by: Bob Liu --- drivers/block/xen-blkback/xenbus.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 3cc6d1d..2e1bb6d 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -159,7 +159,6 @@ static int xen_blkif_alloc_rings(struct xen_blkif *blkif) init_waitqueue_head(&ring->shutdown_wq); ring->blkif = blkif; ring->st_print = jiffies; - xen_blkif_get(blkif); } return 0; @@ -296,7 +295,6 @@ static int xen_blkif_disconnect(struct xen_blkif *blkif) BUG_ON(ring->free_pages_num != 0); BUG_ON(ring->persistent_gnt_c != 0); WARN_ON(i != (XEN_BLKIF_REQS_PER_PAGE * blkif->nr_ring_pages)); - xen_blkif_put(blkif); } blkif->nr_ring_pages = 0; /* -- 1.7.10.4