From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161056AbcIZLKT (ORCPT ); Mon, 26 Sep 2016 07:10:19 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:60054 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965095AbcIZLIa (ORCPT ); Mon, 26 Sep 2016 07:08:30 -0400 From: Stefan Wahren To: "David S. Miller" , Greg Kroah-Hartman , Jiri Slaby Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH RFC v2 net-next 2/8] net: qca_debug: use net_device_ops instead of direct call Date: Mon, 26 Sep 2016 13:08:00 +0200 Message-Id: <1474888086-514-3-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1474888086-514-1-git-send-email-stefan.wahren@i2se.com> References: <1474888086-514-1-git-send-email-stefan.wahren@i2se.com> X-Provags-ID: V03:K0:Gi4H8zyszJn0Fsy3MhMrWAJasjedZvnEICdyTDdb+htlRHWzCEZ ljTYA7OL3H8TPFd2EquMmIsvwYGrWspUQmEPo4e6MtdgPvUYJpdBzy5nv0d+2SggT0PU02Q lc8NgpYuoTCxpnuXTbXps8sVad9280NU+3qUhVphenTUXpmHVK7dwIxWmOxHIXljTvMTF9y Bk9XwPkt3rpy3OTZM0OSg== X-UI-Out-Filterresults: notjunk:1;V01:K0:cXZb/q8Wp7Q=:hFwLXMdXdJWRKah2NhSfsi ehDzlgHGrmdXmJyvia/GO1dUvalxg4CI23DSZaGI5O8vyUclIBtyEzdHTbYDRPPWb0N7qweaL UbrRy3yW/nwBGpQVPwOrfm9/o0yKgkZKUNvIXauVXqpsKbo+kE+yI2tNlxyhh9fH0ZGjmMzac qoH/DNFlg9HoTk9eaZ4735XyyGdSvQCb7IeWQMpukCF4nC7sge4rfK+XEOrYiH2XTjqAfsnG1 vVGvzwi52hOhCEyqMRXs/y0AomVz4lyNE2ml8TVCMzg7TLGtsrzxGqlpikPLxYSYrHaah0moH cgRO/UrjtARgbovEQLiCQhuBxV88MYu0Rbt/BRJo7yo3FAnYlE+dlQCO7VpGj/8KoqVICYrT9 iiXVmzaS9N9FANRyhzs39qxrqBCZShILmv1HSkLMA37lko66HP1diMzntpn49y3QqsE+e7iPx qcykiBtsIfV9OiSo4N94F8NAFY/eav00g/Gg4G8QLZhaacng4HFNcXs8FZ+6TIKF0bc2+UOsI X8DCx5QfhZtpwGGLhNhTud8lOFe/JDeYoj0QH3hSHhXODGY21dlgeZwy1JdVSeIn7/UDBb7jL kaUDw3AF8MP4sdvhr/McrWMqaZYPtnt3F8NIj9cauUD/KqWsFLU90UVSLhm9MuRWywDYPps9N +8bo6fi9YpFKfp5wJMRsoHkFf3OYPsq1Ctx3vOosfXSG64fS21IK5w0mMJzs2R9gTvTA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.h | 3 --- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index 8e28234..851bf07 100644 --- a/drivers/net/ethernet/qualcomm/qca_debug.c +++ b/drivers/net/ethernet/qualcomm/qca_debug.c @@ -273,6 +273,7 @@ qcaspi_get_ringparam(struct net_device *dev, struct ethtool_ringparam *ring) static int qcaspi_set_ringparam(struct net_device *dev, struct ethtool_ringparam *ring) { + const struct net_device_ops *ops = dev->netdev_ops; struct qcaspi *qca = netdev_priv(dev); if ((ring->rx_pending) || @@ -281,13 +282,13 @@ qcaspi_set_ringparam(struct net_device *dev, struct ethtool_ringparam *ring) return -EINVAL; if (netif_running(dev)) - qcaspi_netdev_close(dev); + ops->ndo_stop(dev); qca->txr.count = max_t(u32, ring->tx_pending, TX_RING_MIN_LEN); qca->txr.count = min_t(u16, qca->txr.count, TX_RING_MAX_LEN); if (netif_running(dev)) - qcaspi_netdev_open(dev); + ops->ndo_open(dev); return 0; } diff --git a/drivers/net/ethernet/qualcomm/qca_spi.h b/drivers/net/ethernet/qualcomm/qca_spi.h index 6e31a0e..064853d 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.h +++ b/drivers/net/ethernet/qualcomm/qca_spi.h @@ -108,7 +108,4 @@ struct qcaspi { u16 burst_len; }; -int qcaspi_netdev_open(struct net_device *dev); -int qcaspi_netdev_close(struct net_device *dev); - #endif /* _QCA_SPI_H */ -- 2.1.4