From: Mark Rutland <mark.rutland@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>, Jiri Slaby <jslaby@suse.com>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: [PATCH 2/3] drivers/tty: Explicitly pass current to show_stack
Date: Mon, 26 Sep 2016 16:16:18 +0100 [thread overview]
Message-ID: <1474902979-18436-3-git-send-email-mark.rutland@arm.com> (raw)
In-Reply-To: <1474902979-18436-1-git-send-email-mark.rutland@arm.com>
As noted in commit:
81539169f283329f ("x86/dumpstack: Remove NULL task pointer convention")
... having a NULL task parameter imply current leads to subtle bugs in stack
walking code (so far seen on both 86 and arm64), makes callsites harder to
read, and is unnecessary as all callers have access to current.
As a step towards removing the problematic NULL-implies-current idiom entirely,
have the sysrq code explicitly pass current to show_stack.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: linux-kernel@vger.kernel.org
---
drivers/tty/sysrq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index 52bbd27..5b1e0ed 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -224,7 +224,7 @@ static void showacpu(void *dummy)
spin_lock_irqsave(&show_lock, flags);
pr_info("CPU%d:\n", smp_processor_id());
- show_stack(NULL, NULL);
+ show_stack(current, NULL);
spin_unlock_irqrestore(&show_lock, flags);
}
--
2.7.4
next prev parent reply other threads:[~2016-09-26 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 15:16 [PATCH 0/3] Kill off show_stack() NULL-implies-current idiom Mark Rutland
2016-09-26 15:16 ` [PATCH 1/3] sched: document that show_stack() should not be passed a NULL task Mark Rutland
2016-09-26 15:16 ` Mark Rutland [this message]
2016-09-26 15:16 ` [PATCH 3/3] lib: dump_stack: explicitly pass current to show_stack Mark Rutland
2016-09-26 20:01 ` [PATCH 0/3] Kill off show_stack() NULL-implies-current idiom Josh Poimboeuf
2016-09-26 21:33 ` Mark Rutland
2016-09-27 17:57 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474902979-18436-3-git-send-email-mark.rutland@arm.com \
--to=mark.rutland@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome