From: Joe Perches <joe@perches.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Sean Paul <seanpaul@chromium.org>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE
Date: Tue, 27 Sep 2016 09:43:35 -0700 [thread overview]
Message-ID: <1474994615.2731.15.camel@perches.com> (raw)
In-Reply-To: <CACvgo53MkYOcBRE4pADH7Fvva=oXxf+x4mDdEWt0ZycKMOEsCw@mail.gmail.com>
On Tue, 2016-09-27 at 17:36 +0100, Emil Velikov wrote:
> On 27 September 2016 at 17:04, Joe Perches <joe@perches.com> wrote:
> > On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote:
> > > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches <joe@perches.com> wrote:
> > > > Use a bit more consistent style with kernel loglevels
> > > I'm not convinced this is worth doing if we're going to keep the
> > > WARN/WARNING discrepancy, and I don't think we should switch DRM_WARN
> > > to DRM_WARNING since it's so widely used.
> > There is no DRM_WARN inconsistency.
> DRM_WARN is to DRM_WARNING like DRM_INFO is to DRM_INFORMATION and
> DRM_NOTE is to DRM_NOTICE...
DRM_INFORMATION doesn't exist in the kernel tree.
> is what I'm thinking and seemingly so
> does Sean. Fwiw that part seem cosmetic/unrelated to the rest of the
> patch, so it might be worth keeping separate ?
To me, simplifying the macro means using the common kernel
macro forms.
next prev parent reply other threads:[~2016-09-27 16:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 2:18 [PATCH 0/2] drm: Neaten and reduce object size Joe Perches
2016-09-26 2:18 ` [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE Joe Perches
2016-09-27 15:58 ` Sean Paul
2016-09-27 16:04 ` Joe Perches
2016-09-27 16:36 ` Emil Velikov
2016-09-27 16:43 ` Joe Perches [this message]
2016-09-27 16:54 ` Emil Velikov
2016-09-27 17:20 ` Sean Paul
2016-09-27 16:56 ` Joe Perches
2016-09-26 2:18 ` [PATCH 2/2] drm: Simplify drm_printk to reduce object size quite a bit Joe Perches
2016-09-26 8:36 ` Chris Wilson
2016-09-27 15:54 ` Sean Paul
2016-09-29 13:32 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474994615.2731.15.camel@perches.com \
--to=joe@perches.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome