From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752280AbcI1IRh (ORCPT ); Wed, 28 Sep 2016 04:17:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45316 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751804AbcI1IQD (ORCPT ); Wed, 28 Sep 2016 04:16:03 -0400 From: Benjamin Tissoires To: Jean Delvare , Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 07/10] i2c: i2c-smbus: remove double warning message Date: Wed, 28 Sep 2016 10:15:46 +0200 Message-Id: <1475050549-25542-8-git-send-email-benjamin.tissoires@redhat.com> In-Reply-To: <1475050549-25542-1-git-send-email-benjamin.tissoires@redhat.com> References: <1475050549-25542-1-git-send-email-benjamin.tissoires@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 28 Sep 2016 08:16:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org i2c_handle_smbus_host_notify() returns an error code when it fails. If the caller wants to warn when an error is returned, we should not partially warn in the function itself. Signed-off-by: Benjamin Tissoires --- no changes in v3 new in v2 --- drivers/i2c/i2c-smbus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c index 35e4f1a..819e5f2 100644 --- a/drivers/i2c/i2c-smbus.c +++ b/drivers/i2c/i2c-smbus.c @@ -347,7 +347,6 @@ int i2c_handle_smbus_host_notify(struct smbus_host_notify *host_notify, if (host_notify->pending) { spin_unlock_irqrestore(&host_notify->lock, flags); - dev_warn(&adapter->dev, "Host Notify already scheduled.\n"); return -EBUSY; } -- 2.7.4