From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932129AbcI1K0i (ORCPT ); Wed, 28 Sep 2016 06:26:38 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33790 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752550AbcI1K0Z (ORCPT ); Wed, 28 Sep 2016 06:26:25 -0400 From: shyam saini To: labbott@redhat.com Cc: sumit.semwal@linaro.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, arve@android.com, shyam saini Subject: [PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style Date: Wed, 28 Sep 2016 15:55:32 +0530 Message-Id: <1475058332-15817-1-git-send-email-mayhs11saini@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the explicit NULL comparison and rewrite in a compact form and fixed switch case indentation issue. Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index de0899a..0b7bb30 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -36,7 +36,7 @@ int ion_parse_dt_heap_common(struct device_node *heap_node, break; } - if (compatible[i].name == NULL) + if (!compatible[i].name) return -ENODEV; heap->id = compatible[i].heap_id; @@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent, int ret = 0; switch (heap->type) { - case ION_HEAP_TYPE_CARVEOUT: - case ION_HEAP_TYPE_CHUNK: - if (heap->base && heap->size) - return 0; - - ret = of_reserved_mem_device_init(heap->priv); - break; - default: - break; + case ION_HEAP_TYPE_CARVEOUT: + case ION_HEAP_TYPE_CHUNK: + if (heap->base && heap->size) + return 0; + + ret = of_reserved_mem_device_init(heap->priv); + break; + default: + break; } return ret; -- 2.7.4