From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 02/87] staging: wlang-ng: avoid new typedef: hfa384x_compident_t
Date: Wed, 28 Sep 2016 18:27:44 +0200 [thread overview]
Message-ID: <1475080149-16658-3-git-send-email-sergio.paracuellos@gmail.com> (raw)
In-Reply-To: <1475080149-16658-1-git-send-email-sergio.paracuellos@gmail.com>
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_compident_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 12 ++++++------
drivers/staging/wlan-ng/prism2fw.c | 6 +++---
drivers/staging/wlan-ng/prism2sta.c | 6 +++---
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 5df4e1f..d462c78 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -367,12 +367,12 @@ struct hfa384x_bytestr32 {
--------------------------------------------------------------------*/
/*-- Hardware/Firmware Component Information ----------*/
-typedef struct hfa384x_compident {
+struct hfa384x_compident {
u16 id;
u16 variant;
u16 major;
u16 minor;
-} __packed hfa384x_compident_t;
+} __packed;
typedef struct hfa384x_caplevel {
u16 role;
@@ -1304,10 +1304,10 @@ struct prism2sta_accesslist {
unsigned int dot11_grpcnt;
/* Component Identities */
- hfa384x_compident_t ident_nic;
- hfa384x_compident_t ident_pri_fw;
- hfa384x_compident_t ident_sta_fw;
- hfa384x_compident_t ident_ap_fw;
+ struct hfa384x_compident ident_nic;
+ struct hfa384x_compident ident_pri_fw;
+ struct hfa384x_compident ident_sta_fw;
+ struct hfa384x_compident ident_ap_fw;
u16 mm_mods;
/* Supplier compatibility ranges */
diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
index 7c5d3e7..35b0ff99 100644
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
@@ -96,10 +96,10 @@ struct s3inforec {
u16 len;
u16 type;
union {
- hfa384x_compident_t version;
+ struct hfa384x_compident version;
hfa384x_caplevel_t compat;
u16 buildseq;
- hfa384x_compident_t platform;
+ struct hfa384x_compident platform;
} info;
};
@@ -152,7 +152,7 @@ struct imgchunk {
/* PDA, built from [card|newfile]+[addfile1+addfile2...] */
static struct pda pda;
-static hfa384x_compident_t nicid;
+static struct hfa384x_compident nicid;
static hfa384x_caplevel_t rfid;
static hfa384x_caplevel_t macid;
static hfa384x_caplevel_t priid;
diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
index ec51db2..6169481 100644
--- a/drivers/staging/wlan-ng/prism2sta.c
+++ b/drivers/staging/wlan-ng/prism2sta.c
@@ -592,7 +592,7 @@ static int prism2sta_getcardinfo(struct wlandevice *wlandev)
/* NIC identity */
result = hfa384x_drvr_getconfig(hw, HFA384x_RID_NICIDENTITY,
&hw->ident_nic,
- sizeof(hfa384x_compident_t));
+ sizeof(struct hfa384x_compident));
if (result) {
netdev_err(wlandev->netdev, "Failed to retrieve NICIDENTITY\n");
goto failed;
@@ -611,7 +611,7 @@ static int prism2sta_getcardinfo(struct wlandevice *wlandev)
/* Primary f/w identity */
result = hfa384x_drvr_getconfig(hw, HFA384x_RID_PRIIDENTITY,
&hw->ident_pri_fw,
- sizeof(hfa384x_compident_t));
+ sizeof(struct hfa384x_compident));
if (result) {
netdev_err(wlandev->netdev, "Failed to retrieve PRIIDENTITY\n");
goto failed;
@@ -630,7 +630,7 @@ static int prism2sta_getcardinfo(struct wlandevice *wlandev)
/* Station (Secondary?) f/w identity */
result = hfa384x_drvr_getconfig(hw, HFA384x_RID_STAIDENTITY,
&hw->ident_sta_fw,
- sizeof(hfa384x_compident_t));
+ sizeof(struct hfa384x_compident));
if (result) {
netdev_err(wlandev->netdev, "Failed to retrieve STAIDENTITY\n");
goto failed;
--
1.9.1
next prev parent reply other threads:[~2016-09-28 16:29 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 16:27 [PATCH 00/87] Fix some style warnings in hfa384x.h Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 01/87] staging: wlang-ng: avoid new typedef: hfa384x_bytestr32_t Sergio Paracuellos
2016-09-28 16:27 ` Sergio Paracuellos [this message]
2016-09-28 16:27 ` [PATCH 03/87] staging: wlang-ng: Fix block comments style warnings in hfa384x.h Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 04/87] staging: wlang-ng: avoid new typedef: hfa384x_caplevel_t Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 05/87] staging: wlang-ng: avoid new typedef: hfa384x_HostScanRequest_data_t Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 06/87] staging: wlang-ng: avoid new typedef: hfa384x_JoinRequest_data_t Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 07/87] staging: wlang-ng: avoid new typedef: hfa384x_authenticateStation_data_t Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 08/87] staging: wlang-ng: avoid new typedef: hfa384x_WPAData_t Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 09/87] staging: wlang-ng: avoid new typedef: hfa384x_downloadbuffer_t Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 10/87] staging: wlang-ng: avoid new typedef: hfa384x_commsquality_t Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 11/87] staging: wlang-ng: avoid new typedef: hfa384x_dbmcommsquality_t Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 12/87] staging: wlang-ng: avoid new typedef: hfa384x_tx_frame_t Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 13/87] staging: wlang-ng: avoid new typedef: hfa384x_rx_frame_t Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 14/87] staging: wlang-ng: avoid new typedef: hfa384x_CommTallies16_t Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 15/87] staging: wlang-ng: avoid new typedef: hfa384x_CommTallies32_t Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 16/87] staging: wlang-ng: avoid new typedef: hfa384x_ScanResultSub_t Sergio Paracuellos
2016-09-28 16:27 ` [PATCH 17/87] staging: wlang-ng: avoid new typedef: hfa384x_ScanResult_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 18/87] staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResultSub_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 19/87] staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResult_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 20/87] staging: wlang-ng: avoid new typedef: hfa384x_HScanResultSub_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 21/87] staging: wlang-ng: avoid new typedef: hfa384x_HScanResult_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 22/87] staging: wlang-ng: avoid new typedef: hfa384x_LinkStatus_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 23/87] staging: wlang-ng: avoid new typedef: hfa384x_AssocStatus_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 24/87] staging: wlang-ng: avoid new typedef: hfa384x_AuthReq_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 25/87] staging: wlang-ng: avoid new typedef: hfa384x_PSUserCount_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 26/87] staging: wlang-ng: avoid new typedef: hfa384x_KeyIDChanged_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 27/87] staging: wlang-ng: avoid new typedef: hfa384x_infodata_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 28/87] staging: wlang-ng: avoid new typedef: hfa384x_InfFrame_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 29/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_txfrm_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 30/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdreq_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 31/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wridreq_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 32/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rridreq_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 33/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemreq_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 34/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemreq_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 35/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rxfrm_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 36/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_infofrm_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 37/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdresp_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 38/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wridresp_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 39/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rridresp_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 40/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemresp_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 41/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemresp_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 42/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_bufavail_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 43/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_error_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 44/87] staging: wlang-ng: avoid new typedef: hfa384x_usbout_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 45/87] staging: wlang-ng: avoid new typedef: hfa384x_usbin_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 46/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_partnum_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 47/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_tracenum_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 48/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_serial_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 49/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_measurements_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 50/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_ramsize_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 51/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mfisuprange_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 52/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_cfisuprange_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 53/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nicid_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 54/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_measurements_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 55/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_measurements_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 56/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_compc_measurements_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 57/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mac_address_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 58/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_callname_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 59/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_regdomain_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 60/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_allowed_channel_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 61/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_default_channel_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 62/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_privacy_option_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 63/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_temptype_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 64/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_setup_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 65/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_setup_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 66/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_comp_setup_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 67/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_trimdac_setup_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 68/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_ifr_setting_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 69/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_rfr_setting_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 70/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_baseline_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 71/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_shadow_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 72/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_ifrf_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 73/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcalsp_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 74/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcali_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 75/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_config_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 76/87] staging: wlang-ng: avoid new typedef: hfa384x_hfo_delay_t Sergio Paracuellos
2016-09-28 16:28 ` [PATCH 77/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testsp_t Sergio Paracuellos
2016-09-28 16:29 ` [PATCH 78/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testi_t Sergio Paracuellos
2016-09-28 16:29 ` [PATCH 79/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_end_of_pda_t Sergio Paracuellos
2016-09-28 16:29 ` [PATCH 80/87] staging: wlang-ng: avoid new typedef: hfa384x_pdrec_t Sergio Paracuellos
2016-09-28 16:29 ` [PATCH 81/87] staging: wlang-ng: avoid new typedef: hfa384x_cmdresult_t Sergio Paracuellos
2016-09-28 16:29 ` [PATCH 82/87] staging: wlang-ng: avoid new typedef: hfa384x_rridresult_t Sergio Paracuellos
2016-09-28 16:37 ` [PATCH 00/87] Fix some style warnings in hfa384x.h Giedrius Statkevičius
2016-09-28 17:40 ` Sergio Paracuellos
2016-09-28 18:18 Sergio Paracuellos
2016-09-28 18:18 ` [PATCH 02/87] staging: wlang-ng: avoid new typedef: hfa384x_compident_t Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475080149-16658-3-git-send-email-sergio.paracuellos@gmail.com \
--to=sergio.paracuellos@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®