mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 85/87] staging: wlang-ng: avoid new typedef: hfa384x_metacmd_t
Date: Wed, 28 Sep 2016 20:20:18 +0200	[thread overview]
Message-ID: <1475086820-24695-86-git-send-email-sergio.paracuellos@gmail.com> (raw)
In-Reply-To: <1475086820-24695-1-git-send-email-sergio.paracuellos@gmail.com>

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_metacmd_t

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 drivers/staging/wlan-ng/hfa384x.h     |  4 ++--
 drivers/staging/wlan-ng/hfa384x_usb.c | 18 +++++++++---------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 736ac31..b97099d 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1206,7 +1206,7 @@ struct hfa384x_usbctlxq {
 	struct list_head reapable;
 };
 
-typedef struct hfa484x_metacmd {
+struct hfa384x_metacmd {
 	u16 cmd;
 
 	u16 parm0;
@@ -1214,7 +1214,7 @@ struct hfa384x_usbctlxq {
 	u16 parm2;
 
 	struct hfa384x_cmdresult result;
-} hfa384x_metacmd_t;
+};
 
 #define	MAX_GRP_ADDR		32
 #define WLAN_COMMENT_MAX	80  /* Max. length of user comment string. */
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 1f0c428..7b0aae5 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -224,7 +224,7 @@ struct usbctlx_completor {
 static int
 hfa384x_docmd(hfa384x_t *hw,
 	      enum cmd_mode mode,
-	      hfa384x_metacmd_t *cmd,
+	      struct hfa384x_metacmd *cmd,
 	      ctlx_cmdcb_t cmdcb, ctlx_usercb_t usercb, void *usercb_data);
 
 static int
@@ -812,14 +812,14 @@ static void hfa384x_cb_status(hfa384x_t *hw, const struct hfa384x_usbctlx *ctlx)
 	}
 }
 
-static inline int hfa384x_docmd_wait(hfa384x_t *hw, hfa384x_metacmd_t *cmd)
+static inline int hfa384x_docmd_wait(hfa384x_t *hw, struct hfa384x_metacmd *cmd)
 {
 	return hfa384x_docmd(hw, DOWAIT, cmd, NULL, NULL, NULL);
 }
 
 static inline int
 hfa384x_docmd_async(hfa384x_t *hw,
-		    hfa384x_metacmd_t *cmd,
+		    struct hfa384x_metacmd *cmd,
 		    ctlx_cmdcb_t cmdcb, ctlx_usercb_t usercb, void *usercb_data)
 {
 	return hfa384x_docmd(hw, DOASYNC, cmd, cmdcb, usercb, usercb_data);
@@ -927,7 +927,7 @@ int hfa384x_cmd_initialize(hfa384x_t *hw)
 {
 	int result = 0;
 	int i;
-	hfa384x_metacmd_t cmd;
+	struct hfa384x_metacmd cmd;
 
 	cmd.cmd = HFA384x_CMDCODE_INIT;
 	cmd.parm0 = 0;
@@ -971,7 +971,7 @@ int hfa384x_cmd_initialize(hfa384x_t *hw)
 ----------------------------------------------------------------*/
 int hfa384x_cmd_disable(hfa384x_t *hw, u16 macport)
 {
-	hfa384x_metacmd_t cmd;
+	struct hfa384x_metacmd cmd;
 
 	cmd.cmd = HFA384x_CMD_CMDCODE_SET(HFA384x_CMDCODE_DISABLE) |
 	    HFA384x_CMD_MACPORT_SET(macport);
@@ -1004,7 +1004,7 @@ int hfa384x_cmd_disable(hfa384x_t *hw, u16 macport)
 ----------------------------------------------------------------*/
 int hfa384x_cmd_enable(hfa384x_t *hw, u16 macport)
 {
-	hfa384x_metacmd_t cmd;
+	struct hfa384x_metacmd cmd;
 
 	cmd.cmd = HFA384x_CMD_CMDCODE_SET(HFA384x_CMDCODE_ENABLE) |
 	    HFA384x_CMD_MACPORT_SET(macport);
@@ -1046,7 +1046,7 @@ int hfa384x_cmd_enable(hfa384x_t *hw, u16 macport)
 ----------------------------------------------------------------*/
 int hfa384x_cmd_monitor(hfa384x_t *hw, u16 enable)
 {
-	hfa384x_metacmd_t cmd;
+	struct hfa384x_metacmd cmd;
 
 	cmd.cmd = HFA384x_CMD_CMDCODE_SET(HFA384x_CMDCODE_MONITOR) |
 	    HFA384x_CMD_AINFO_SET(enable);
@@ -1098,7 +1098,7 @@ int hfa384x_cmd_monitor(hfa384x_t *hw, u16 enable)
 int hfa384x_cmd_download(hfa384x_t *hw, u16 mode, u16 lowaddr,
 			 u16 highaddr, u16 codelen)
 {
-	hfa384x_metacmd_t cmd;
+	struct hfa384x_metacmd cmd;
 
 	pr_debug("mode=%d, lowaddr=0x%04x, highaddr=0x%04x, codelen=%d\n",
 		 mode, lowaddr, highaddr, codelen);
@@ -1291,7 +1291,7 @@ static int hfa384x_usbctlx_complete_sync(hfa384x_t *hw,
 static int
 hfa384x_docmd(hfa384x_t *hw,
 	      enum cmd_mode mode,
-	      hfa384x_metacmd_t *cmd,
+	      struct hfa384x_metacmd *cmd,
 	      ctlx_cmdcb_t cmdcb, ctlx_usercb_t usercb, void *usercb_data)
 {
 	int result;
-- 
1.9.1

  parent reply	other threads:[~2016-09-28 18:28 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 18:18 [PATCH 00/87] Fix some style warnings in hfa384x.h Sergio Paracuellos
2016-09-28 18:18 ` [PATCH 01/87] staging: wlang-ng: avoid new typedef: hfa384x_bytestr32_t Sergio Paracuellos
2016-09-28 18:18 ` [PATCH 02/87] staging: wlang-ng: avoid new typedef: hfa384x_compident_t Sergio Paracuellos
2016-09-28 18:18 ` [PATCH 03/87] staging: wlang-ng: Fix block comments style warnings in hfa384x.h Sergio Paracuellos
2016-09-28 18:18 ` [PATCH 04/87] staging: wlang-ng: avoid new typedef: hfa384x_caplevel_t Sergio Paracuellos
2016-09-28 18:18 ` [PATCH 05/87] staging: wlang-ng: avoid new typedef: hfa384x_HostScanRequest_data_t Sergio Paracuellos
2016-09-28 18:18 ` [PATCH 06/87] staging: wlang-ng: avoid new typedef: hfa384x_JoinRequest_data_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 07/87] staging: wlang-ng: avoid new typedef: hfa384x_authenticateStation_data_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 08/87] staging: wlang-ng: avoid new typedef: hfa384x_WPAData_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 09/87] staging: wlang-ng: avoid new typedef: hfa384x_downloadbuffer_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 10/87] staging: wlang-ng: avoid new typedef: hfa384x_commsquality_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 11/87] staging: wlang-ng: avoid new typedef: hfa384x_dbmcommsquality_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 12/87] staging: wlang-ng: avoid new typedef: hfa384x_tx_frame_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 13/87] staging: wlang-ng: avoid new typedef: hfa384x_rx_frame_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 14/87] staging: wlang-ng: avoid new typedef: hfa384x_CommTallies16_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 15/87] staging: wlang-ng: avoid new typedef: hfa384x_CommTallies32_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 16/87] staging: wlang-ng: avoid new typedef: hfa384x_ScanResultSub_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 17/87] staging: wlang-ng: avoid new typedef: hfa384x_ScanResult_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 18/87] staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResultSub_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 19/87] staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResult_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 20/87] staging: wlang-ng: avoid new typedef: hfa384x_HScanResultSub_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 21/87] staging: wlang-ng: avoid new typedef: hfa384x_HScanResult_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 22/87] staging: wlang-ng: avoid new typedef: hfa384x_LinkStatus_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 23/87] staging: wlang-ng: avoid new typedef: hfa384x_AssocStatus_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 24/87] staging: wlang-ng: avoid new typedef: hfa384x_AuthReq_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 25/87] staging: wlang-ng: avoid new typedef: hfa384x_PSUserCount_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 26/87] staging: wlang-ng: avoid new typedef: hfa384x_KeyIDChanged_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 27/87] staging: wlang-ng: avoid new typedef: hfa384x_infodata_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 28/87] staging: wlang-ng: avoid new typedef: hfa384x_InfFrame_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 29/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_txfrm_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 30/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdreq_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 31/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wridreq_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 32/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rridreq_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 33/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemreq_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 34/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemreq_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 35/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rxfrm_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 36/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_infofrm_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 37/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdresp_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 38/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wridresp_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 39/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rridresp_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 40/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemresp_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 41/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemresp_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 42/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_bufavail_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 43/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_error_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 44/87] staging: wlang-ng: avoid new typedef: hfa384x_usbout_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 45/87] staging: wlang-ng: avoid new typedef: hfa384x_usbin_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 46/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_partnum_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 47/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_tracenum_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 48/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_serial_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 49/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_measurements_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 50/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_ramsize_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 51/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mfisuprange_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 52/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_cfisuprange_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 53/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nicid_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 54/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_measurements_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 55/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_measurements_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 56/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_compc_measurements_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 57/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mac_address_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 58/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_callname_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 59/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_regdomain_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 60/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_allowed_channel_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 61/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_default_channel_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 62/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_privacy_option_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 63/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_temptype_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 64/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_setup_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 65/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_setup_t Sergio Paracuellos
2016-09-28 18:19 ` [PATCH 66/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_comp_setup_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 67/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_trimdac_setup_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 68/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_ifr_setting_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 69/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_rfr_setting_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 70/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_baseline_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 71/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_shadow_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 72/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_ifrf_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 73/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcalsp_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 74/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcali_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 75/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_config_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 76/87] staging: wlang-ng: avoid new typedef: hfa384x_hfo_delay_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 77/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testsp_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 78/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testi_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 79/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_end_of_pda_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 80/87] staging: wlang-ng: avoid new typedef: hfa384x_pdrec_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 81/87] staging: wlang-ng: avoid new typedef: hfa384x_cmdresult_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 82/87] staging: wlang-ng: avoid new typedef: hfa384x_rridresult_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 83/87] staging: wlang-ng: avoid new typedef: hfa384x_usbctlx_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 84/87] staging: wlang-ng: avoid new typedef: hfa384x_usbctlxq_t Sergio Paracuellos
2016-09-28 18:20 ` Sergio Paracuellos [this message]
2016-09-28 18:20 ` [PATCH 86/87] staging: wlang-ng: avoid new typedef: hfa384x_t Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 87/87] staging: wlang-ng: Fix block comments style warnings in hfa384x.h Sergio Paracuellos
2016-10-02 15:07 ` [PATCH 00/87] Fix some " Greg KH
2016-10-02 16:52   ` Sergio Paracuellos
  -- strict thread matches above, loose matches on Subject: below --
2016-09-28 17:17 [PATCH 85/87] staging: wlang-ng: avoid new typedef: hfa384x_metacmd_t Sergio Paracuellos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475086820-24695-86-git-send-email-sergio.paracuellos@gmail.com \
    --to=sergio.paracuellos@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®