From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754943AbcI1V1x (ORCPT ); Wed, 28 Sep 2016 17:27:53 -0400 Received: from smtprelay0197.hostedemail.com ([216.40.44.197]:50627 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754927AbcI1V1n (ORCPT ); Wed, 28 Sep 2016 17:27:43 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3867:4321:4605:5007:6642:9149:10004:10400:10848:11026:11232:11473:11658:11914:12043:12438:12740:13069:13311:13357:13439:13894:14093:14097:14181:14659:14721:21080:21451:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: vest55_8a202b34453f X-Filterd-Recvd-Size: 2060 Message-ID: <1475098057.2685.15.camel@perches.com> Subject: Re: [PATCH] Staging : fbtft: Removed "line over 80 characters" Warnings From: Joe Perches To: Harman Kalra , thomas.petazzoni@free-electrons.com, noralf@tronnes.org Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Wed, 28 Sep 2016 14:27:37 -0700 In-Reply-To: <1475094672-4895-1-git-send-email-harman4linux@gmail.com> References: <1475094672-4895-1-git-send-email-harman4linux@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-09-29 at 02:01 +0530, Harman Kalra wrote: > Removed "line over 80 characters" Warnings using checkpatch.pl [] > diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h [] > @@ -402,7 +407,9 @@ static void __exit fbtft_driver_module_exit(void) \ >  #define fbtft_init_dbg(dev, format, arg...) \ >  do { \ >   if (unlikely((dev)->platform_data && \ > - (((struct fbtft_platform_data *)(dev)->platform_data)->display.debug & DEBUG_DRIVER_INIT_FUNCTIONS))) \ > + (((struct fbtft_platform_data *) \ > + (dev)->platform_data)->display.debug \ > + & DEBUG_DRIVER_INIT_FUNCTIONS))) \ >   dev_info(dev, format, ##arg); \ >  } while (0) A nicer way to do might be a statement expression macro #define fbtft_init_dbg(dev, format, ...) \ ({ \ struct fbtft_platform_data *pdata; \ pdata = (struct fbtft_platform_data *)((dev)->platform_data); \ if (unlikely(pdata && \ pdata->display.debug & DEBUG_DRIVER_INIT_FUNCTIONS)) \ dev_info(dev, format, ##__VA_ARGS__); })