From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755861AbcI2UVO (ORCPT ); Thu, 29 Sep 2016 16:21:14 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33279 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755499AbcI2UVF (ORCPT ); Thu, 29 Sep 2016 16:21:05 -0400 From: Wookje Kwon To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Jiri Olsa , Namhyung Kim , Taeung Song , Wookje Kwon Subject: [PATCH] perf config: Fix a bug about permission checking state of config file Date: Fri, 30 Sep 2016 05:20:56 +0900 Message-Id: <1475180456-5624-1-git-send-email-aweee0@gmail.com> X-Mailer: git-send-email 2.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org perf_config_set__init() check state of user config file before opening it. But there is a bug when checking uid and euid of current user. Although current user have superuser permission, a error occurs as below. Before: user01@localhost:~$ ls -l ~/.perfconfig -rw-rw-r-- 1 user01 user01 89 2016-09-30 01:52 /home/user01/.perfconfig user01@localhost:~/linux-perf/tools/perf/util$ sudo perf config --list Warning: File /home/user01/.perfconfig not owned by current user or root, ignoring it. Warning: File /home/user01/.perfconfig not owned by current user or root, ignoring it. So, Fix it allowing a user who have superuser permission to open user config file. After: user01@localhost:~$ ls -l ~/.perfconfig -rw-rw-r-- 1 user01 user01 89 2016-09-30 01:52 /home/user01/.perfconfig user01@localhost:~$ sudo perf config --list annotate.hide_src_code=false report.queue-size=0 tui.report=on colors.top=red, default Cc: Taeung Song Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Wookje Kwon --- tools/perf/util/config.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index 18dae74..f390ef9db 100644 --- a/tools/perf/util/config.c +++ b/tools/perf/util/config.c @@ -619,6 +619,7 @@ static int perf_config_set__init(struct perf_config_set *set) if (perf_config_global() && home) { char *user_config = strdup(mkpath("%s/.perfconfig", home)); struct stat st; + unsigned int st_euid = geteuid(); if (user_config == NULL) { warning("Not enough memory to process %s/.perfconfig, " @@ -629,7 +630,7 @@ static int perf_config_set__init(struct perf_config_set *set) if (stat(user_config, &st) < 0) goto out_free; - if (st.st_uid && (st.st_uid != geteuid())) { + if (st.st_uid && st_euid && (st.st_uid != st_euid)) { warning("File %s not owned by current user or root, " "ignoring it.", user_config); goto out_free; -- 2.1.0