From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933125AbcI3M3y (ORCPT <rfc822;w@1wt.eu>);
        Fri, 30 Sep 2016 08:29:54 -0400
Received: from s3.sipsolutions.net ([5.9.151.49]:42655 "EHLO sipsolutions.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932418AbcI3M3s (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 30 Sep 2016 08:29:48 -0400
Message-ID: <1475238579.17481.56.camel@sipsolutions.net>
Subject: Re: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes
From: Johannes Berg <johannes@sipsolutions.net>
To: Johannes Thumshirn <jthumshirn@suse.de>,
        Solomon Peachy <pizza@shaftnet.org>, Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Fri, 30 Sep 2016 14:29:39 +0200
In-Reply-To: <1475237495-15030-1-git-send-email-jthumshirn@suse.de> (sfid-20160930_141208_240938_8F56ACB3)
References: <1475237495-15030-1-git-send-email-jthumshirn@suse.de>
         (sfid-20160930_141208_240938_8F56ACB3)
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> +	tmp = krealloc(buf->begin, size, GFP_KERNEL | GFP_DMA);
> +	if (tmp) {
> 
I think that check is inverted?

johannes