From: Joe Perches <joe@perches.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c
Date: Mon, 03 Oct 2016 11:18:23 -0700 [thread overview]
Message-ID: <1475518703.24781.4.camel@perches.com> (raw)
In-Reply-To: <57F29F79.5060301@gmail.com>
On Mon, 2016-10-03 at 20:12 +0200, Sergio Paracuellos wrote:
> El 2016年10月03日 a las 18:16, Joe Perches escribió:
> > Perhaps better as hw->scanresults = kmemdup(inf, sizeof(*inf), GFP_ATOMIC);
> I agree. But because all the code is full of sizeof(struct xxx) I though
> it would be bettter to follow the actual style and not change only one...
> I don't have any problem in fix this patch and resend it. What should I do?
I suggest not fixing this patch.
Maybe just send another patch changing all the applicable
sizeof(struct <foo>) uses to sizeof(*var) with the appropriate
line wrapping.
next prev parent reply other threads:[~2016-10-03 18:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 16:04 [PATCH 00/15] staging: wlang-ng: Fix several style issues in several source files Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 01/15] staging: wlang-ng: fix line style warnings in hfa384x_usb.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 02/15] staging: wlang-ng: fix block comment " Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 03/15] staging: wlang-ng: fix block comment warnings in p80211conv.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 04/15] staging: wlang-ng: fix line style warnings in p80211netdev.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 05/15] staging: wlang-ng: fix block comment " Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 06/15] staging: wlang-ng: do not return -ENOSYS Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 07/15] staging: wlang-ng: fix block comment warnings in p80211req.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 08/15] staging: wlang-ng: fix line style " Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 09/15] staging: wlang-ng: fix block comment warnings in p80211wep.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 10/15] staging: wlang-ng: fix line style " Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 11/15] staging: wlang-ng: fix block comment warnings in prism2mgmt.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 12/15] staging: wlang-ng: fix block comment warnings in prism2mib.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 13/15] staging: wlang-ng: fix block comment warnings in prism2sta.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 14/15] staging: wlang-ng: fix line style " Sergio Paracuellos
2016-10-03 16:16 ` Joe Perches
2016-10-03 18:12 ` Sergio Paracuellos
2016-10-03 18:18 ` Joe Perches [this message]
2016-10-04 4:45 ` Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 15/15] staging: wlang-ng: fix block comment warnings in prism2fw.c Sergio Paracuellos
2016-10-09 14:31 ` [PATCH 00/15] staging: wlang-ng: Fix several style issues in several source files Greg KH
2016-10-09 15:10 ` [PATCH 00/15] staging: wlan-ng: " Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 01/15] staging: wlan-ng: fix line style warnings in hfa384x_usb.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 02/15] staging: wlan-ng: fix block comment " Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 03/15] staging: wlan-ng: fix block comment warnings in p80211conv.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 04/15] staging: wlan-ng: fix line style warnings in p80211netdev.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 05/15] staging: wlan-ng: fix block comment " Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 06/15] staging: wlan-ng: do not return -ENOSYS Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 07/15] staging: wlan-ng: fix block comment warnings in p80211req.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 08/15] staging: wlan-ng: fix line style " Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 09/15] staging: wlan-ng: fix block comment warnings in p80211wep.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 10/15] staging: wlan-ng: fix line style " Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 11/15] staging: wlan-ng: fix block comment warnings in prism2mgmt.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 12/15] staging: wlan-ng: fix block comment warnings in prism2mib.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 13/15] staging: wlan-ng: fix block comment warnings in prism2sta.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 14/15] staging: wlan-ng: fix line style " Sergio Paracuellos
2016-10-09 15:23 ` Greg KH
2016-10-09 15:43 ` Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 15/15] staging: wlan-ng: fix block comment warnings in prism2fw.c Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475518703.24781.4.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome